Fix multilib flags of AArch64 soft nofp #600
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes the multilib flags required to select the AArch64 soft nofp variants.
The
+nofp
and+nosimd
arch extensions are specified in the-march
or-mcpu
command line options. Before this patch, the multilib flags specified this part as-march=armv8-a+nofp+nosimd
, however this does not work for any architecture greater than v8, including point releases, nor does it for any-mcpu
value whose underlying architecture is greater than v8. In the formed case because any point release would lead to a regular expression mismatch; and in the latter,-mcpu
option processing introduces extra architecture extensions in the string.Hence the correct way is to match agains
-march=armvX+nofp
and-march=armvX+nosimd
. These two multilib flags are inserted by our implementation ofmultilib.yaml
when+nofp
and+nosimd
are present anywhere in the-march=
or-mcpu=
values, respectively.