[aaelf64] Fix PAuthABI relocation details. #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM
github seems to interpret |
smithp35
force-pushed
the
pauthaaelf64relocs
branch
from
c87b0b1
to
0a555a9
Compare
|
Rebased after #272 the dynamic relocation is akin to R_AARCH64_ABS64 which isn't GOT generating so we can support addends, no further changes needed. Summary of changes:
|
stuij
reviewed
Aug 20, 2024
There is a typo in the spelling of R_<CLS_ABS64, it is missing a close angle brackets, and should be R_<CLS>_ABS64. Similarly there should only be one entry in the dynamic relocation table, with R_<CLS>_ABS64 retaining the static relocation code but using the dynamic relocation semantics. Added a clarifying line to state that the R_<CLS>_ABS64 is both a static and dynamic relocation.
smithp35
force-pushed
the
pauthaaelf64relocs
branch
from
0a555a9
to
2eac09f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a typo in the spelling of R_<CLS_ABS64, it is missing a close angle brackets, and should be R__ABS64.
Similarly there should only be one entry in the dynamic relocation table, with R__ABS64 retaining the static relocation code but using the dynamic relocation semantics.
Added a clarifying line to state that the R__ABS64 is both a static and dynamic relocation.