Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nordic NRF52840 USB Dongle board #15504

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

hallard
Copy link
Contributor

@hallard hallard commented Apr 4, 2024

Added Nordic NRF52840 USB Dongle board

Summary of changes

Impact of changes

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@jeromecoutant


added NRF52840 Dongle
fixed missing library
fixed deprecated pin name
use define for led, button, spi and i2c
added NRF52840_DONGLE
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 10, 2024

Can you please attach test logs for this addition to the first comment? It should be part of every new target addition.

@0xc0170 0xc0170 added needs: review scope: new-target release-type: patch Indentifies a PR as containing just a patch labels Apr 10, 2024
@mbed-ci
Copy link

mbed-ci commented Apr 23, 2024

Jenkins CI Test : ❌ FAILED

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM
jenkins-ci/mbed-os-ci_build-greentea-ARM
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️

@0xc0170 0xc0170 changed the title Added Nordic NRF52840 USB Dongle board Add Nordic NRF52840 USB Dongle board Apr 24, 2024
@0xc0170
Copy link
Contributor

0xc0170 commented May 27, 2024

Can you run some tests (it uses the implementation provided just checking if the device is properly configured).

@hallard
Copy link
Contributor Author

hallard commented May 27, 2024

I'll try to do that tomorrow, sorry for delay, could you remind me test command you want results for?

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 8, 2024

I haven't run the tests for some time but as I recall if you use arguments platform and toolchain, it would run the default set of tests for that platform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: review release-type: patch Indentifies a PR as containing just a patch scope: new-target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants