Skip to content

[Fix/#221] 회의정보입력페이지 선호시간로직 중복시간입력 에러 #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 32 commits into from
Dec 27, 2023
Merged

[Fix/#221] 회의정보입력페이지 선호시간로직 중복시간입력 에러 #222

merged 32 commits into from
Dec 27, 2023

Conversation

ljh0608
Copy link
Member

@ljh0608 ljh0608 commented Nov 7, 2023 •
edited
Loading

✨ 해당 이슈 번호 ✨

#221

todo

  • 첫 로딩때 meetingInfo의 preferTimes를 삭제하는걸로 에러 발생하지 않게함
  • meetingInfo 초기값 startTime:00:00, endTime 00:00 추가해서 undefined 에러 발생 막음

📌 내가 알게 된 부분

  • 서버랑 공유하는 데이터를 잘 설계해서 이걸로 렌더링했어야 관리가 더 쉬웠을 것 같다. 지금은 버튼 상태, 선호시간 입력상태, 그리고 선호시간 입력을 서버에 전송하는 데이터로 입력하는 과정까지 더해져서 굉장히 복잡해짐

📌 질문할 부분

  • meetingInfo 의 preferTImes를 상수로 넣어두고 이부분을 true false로 관리하는게 프론트 입장에서 더 용이할 것 같은데 어떻게 생각하시나요 저도 제 생각이 맞는지 모르겠어요

📌스크린샷

Chanwoo-Jeong and others added 26 commits July 18, 2023 15:59
@Chanwoo-Jeong
Merge pull request #72 from ASAP-as-soon-as-possible/develop
7b7df54 
First Deploy
@Chanwoo-Jeong
Merge pull request #73 from ASAP-as-soon-as-possible/develop
dfbbf68 
배포 라우팅 처리
@Chanwoo-Jeong
Merge pull request #74 from ASAP-as-soon-as-possible/develop
8834337 
fix: 중복 라우터 제거
@Chanwoo-Jeong
Merge pull request #75 from ASAP-as-soon-as-possible/develop
eeef889 
fix: ErrorPage router div 제거
@Chanwoo-Jeong
Merge pull request #79 from ASAP-as-soon-as-possible/develop
2550f62 
css important deploy
@Chanwoo-Jeong
Merge pull request #81 from ASAP-as-soon-as-possible/develop
6f6dab9 
hover event 삭제
@Chanwoo-Jeong
Merge pull request #118 from ASAP-as-soon-as-possible/develop
57aba71 
deploy ts 검사 07/20 오후 7시 11
@Chanwoo-Jeong
Merge pull request #119 from ASAP-as-soon-as-possible/develop
9c380d8 
deploy ts 검사
@Chanwoo-Jeong
Merge pull request #150 from ASAP-as-soon-as-possible/develop
c6beba6 
deploy
@Chanwoo-Jeong
Merge pull request #151 from ASAP-as-soon-as-possible/develop
31fc9bc 
deploy: env edit
@Chanwoo-Jeong
Merge pull request #157 from ASAP-as-soon-as-possible/develop
440c45e 
deploy final
@Chanwoo-Jeong
Merge pull request #158 from ASAP-as-soon-as-possible/develop
4cd6bd7 
feat: 링크 이미지 공유
@simeunseo
Merge pull request #159 from ASAP-as-soon-as-possible/develop
2338086 
[Fix] 온보딩 페이지 오타 수정
@Chanwoo-Jeong
feat: 통합검색을 위한 metatag 등록
12aff94
@Chanwoo-Jeong
deploy: 통합검색을 위한 robots.txt , sitemap.xml 추가
9749972
@Chanwoo-Jeong
Merge pull request #164 from ASAP-as-soon-as-possible/develop
a543a74 
feat: deploy Tally & Navigation
@Chanwoo-Jeong
deploy: index.html meta description 태그 추가
dd0b82f
@ljh0608
Merge pull request #176 from ASAP-as-soon-as-possible/develop
bb3ca5e 
release 1.0.0 -> main
@ljh0608
Merge pull request #190 from ASAP-as-soon-as-possible/develop
f7966be 
release 1.0.1 -> main
@ljh0608
release 1.0.2 -> main
3f555c6 
release 1.0.2 -> main
@simeunseo
Merge pull request #214 from ASAP-as-soon-as-possible/develop
6ec6c16 
release 1.0.2 -> main
@ljh0608
fix: 시간 삭제시 에러해결
b2f2fa5
@ljh0608
hotfix: 비밀번호 숨김처리 다시 적용
a027ae5
@ljh0608
Fix/hide password/#215
58f73eb 
Fix/hide password/#215
@simeunseo
Merge pull request #218 from ASAP-as-soon-as-possible/develop
b312e38 
release 1.0.2 -> main
@ljh0608
fix: 첫로딩때 meetingInfo prefertime지워주는 로직 추가
8cd4404
@ljh0608 ljh0608 added fix fix 재훈 재훈이의 개발 라벨 labels Nov 7, 2023
@ljh0608 ljh0608 self-assigned this Nov 7, 2023
@vercel Vercel
Copy link

vercel bot commented Nov 7, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
asap ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2023 7:11am

@github-actions github-actions bot added the size/S label Nov 7, 2023
@github-actions github-actions bot added size/L and removed size/S labels Nov 7, 2023
@ljh0608 ljh0608 merged commit b841815 into develop Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ljh0608 ljh0608

Labels
fix fix size/L 재훈 재훈이의 개발 라벨
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ljh0608 @Chanwoo-Jeong @simeunseo