Merged
Conversation
jhkennedy
previously approved these changes
Feb 27, 2026
jhkennedy
left a comment
jhkennedy
left a comment
There was a problem hiding this comment.
This looks good.
The only thing worth considering is whether we need three different buckets and prefixes. Is that just to facilitate testing?
Contributor
Author
|
I could reuse the |
jhkennedy
previously approved these changes
Feb 28, 2026
jhkennedy
left a comment
jhkennedy
left a comment
There was a problem hiding this comment.
Looks good! I think if you're going to keep the input prefix argument, you may as well keep the input bucket one.
Approving either way.
Contributor
Author
|
No problem, I added the |
jhkennedy
approved these changes
Feb 28, 2026
github-project-automation
bot
moved this from Needs Review
to Done
in SciDev Team Board
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds parameters to upload products to s3 bucket.