-
Notifications
You must be signed in to change notification settings - Fork 1
[50] ensure multi-realm-scoped value in the nodeRequestScopedFeaturesStoreFactory export of the features package #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TomStrepsil
wants to merge
18
commits into
ASOS:main
Choose a base branch
from
TomStrepsil:feature/50-ensure-realm-scoped-node-request-scoped-features-store-factory
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* rename to proper module namespace * update docs links * update versions * web toggle point in readme title * fixup changelog from revised 0.x range * 2.0.0 -> 0.5.0 in oss version scheme * fix broken link syntax in CHANGELOG * consistent quoting * more version history issues * fixup module name in jsdoc * add web remove sdkInstanceProvider * remove SDKInstanceProvider * fixup jsdoc dedupe * tweak * clarity re: ssr package * casing etc
* update workflows * version * typo * update chromium linux snaps * versions for serve update * package.json repository field * update root package.lock * bugs & directories/doc fields * fix changelog --------- Co-authored-by: Tom Pereira <tom.pereira@johnlewis.co.uk>
Co-authored-by: Tom Pereira <tom.pereira@johnlewis.co.uk>
rename of nodeRequestScopedFeaturesStoreFactory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
resolves #50
Details
FeaturesStoreFactory
interface, mandating that all features stores are created with a namedtoggleType
nodeRequestScopedFeaturesStoreFactory
this is used to key the features store against a a runtime-wide global symbol to ensure it can be shared in cross-realm runtimes (e.g. NextJS). Hence, there can only be a single features store per namedtoggleType
, for this store type. Seeexpress-http-context
for similar.name
property thereactContextFeaturesStoreFactory
, required previously to provide a nicedisplayName
for the react context provider. Its also used to form part of theid
of the backing script for thessrBackedReactContextFeaturesStoreFactory
Scout Rule
nodeRequestScopedStoreFactory
tonodeRequestScopedFeaturesStoreFactory
, for consistencyvaltio
examples in theREADME.md
Upgrade guide
This change will represent breaking changes in consumers of the features package.
Any use of stores now require a
toggleType
property, replacing thename
that may have come before. It should represent the type of toggle, e.g."experiments"
.Any name import of
nodeRequestScopedStoreFactory
should now importnodeRequestScopedFeaturesStoreFactory
CheckList
main
.