Add changes to support URL redirection. #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@francisbrosnan Any suggestion on this pull request? |
|
Hello @mrigaya |
mrigaya
force-pushed
the
nopoll_redirect
branch
from
ac428a6 to
01f5c11
Compare
|
@francisbrosnan What do you think about this PR, can we move forward with it? |
|
@mrigaya & @francisbrosnan Has any progress been made on the CLA agreement? We'd like to use this code, but it's stuck as a PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Server URL redirection is not handled in nopoll.
As per RFC https://tools.ietf.org/html/rfc6455#section-4.2.2, library/server should handle non 101 status code received during handshake. Currently nopoll is not handling this feature, whenever it receives non 101 status code will close the connection and not supporting any other functionality like URL redirection in case of 3xx status code is received.
These changes may handle this scenario, if server sends redirection URL to the user/client using a 3xx status code, the user/client may establish connection with the redirected URL.
Review these changes and Please let me know if it requires any modification/suggestion from your end.