BF: Decouples the Tk process from its calling process. #474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means Tk will not be automatically closed when the main process exits.
Codecov Report
@@ Coverage Diff @@
## master #474 +/- ##
==========================================
+ Coverage 65.85% 65.88% +0.02%
==========================================
Files 30 30
Lines 3983 3986 +3
==========================================
+ Hits 2623 2626 +3
Misses 1360 1360
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means Tk will not be automatically closed when the main process exits.
Lacks proper testing on Windows, so do not merge yet. The PR is mostly for reference and as a quick fix for #451 (mostly to allow for playing proper tournaments again. see: #456).
A better solution would explicitly have the supervising process take control of Tk (for example by running the viewer manually before starting the game). For the tournament this could also become an improvement: Having one Tk window for all the games that never closes.