Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create rainbow ring around theme switcher icon #75

Merged
merged 10 commits into from
Mar 10, 2024
Merged

Create rainbow ring around theme switcher icon #75

merged 10 commits into from
Mar 10, 2024

Conversation

AVGVSTVS96
Copy link
Owner

@AVGVSTVS96 AVGVSTVS96 commented Mar 9, 2024

  • Fix inconsistencies in vertical centering by keeping a constant text size in NavBar, adding items-center to Button, and making the caret in Button a consistent size regardless of viewport width

  • Add named slot to Button and pass through DropdownMenu to ThemeSwitcher

  • Use CSS conic gradient to create rainbow ring for ThemeSwitcher

Copy link

codesandbox bot commented Mar 9, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@AVGVSTVS96 AVGVSTVS96 marked this pull request as ready for review March 9, 2024 01:12
@AVGVSTVS96 AVGVSTVS96 marked this pull request as draft March 9, 2024 01:13
Copy link

cloudflare-workers-and-pages bot commented Mar 9, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: af64d10
Status: ✅  Deploy successful!
Preview URL: https://2baa3764.astrosite-aid.pages.dev
Branch Preview URL: https://ring.astrosite-aid.pages.dev

View logs

@AVGVSTVS96 AVGVSTVS96 marked this pull request as ready for review March 10, 2024 03:00
@AVGVSTVS96 AVGVSTVS96 merged commit 5d343a2 into master Mar 10, 2024
3 checks passed
@AVGVSTVS96 AVGVSTVS96 deleted the ring branch March 10, 2024 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant