Skip to content

Conversation

ReeceHumphreys
Copy link
Contributor

@ReeceHumphreys ReeceHumphreys commented Sep 26, 2025

  • Tickets addressed: N/A
  • Review: By commit
  • Merge strategy: Merge (no squash)

Description

Some workflows are timing out before they finish running, this increases the timeout to 2 hours to avoid this. We may not merge this PR as I suspect the real issue people are having is just tests hanging.

Verification

N/A

Documentation

N/A

Future work

N/A

@ReeceHumphreys ReeceHumphreys requested a review from a team as a code owner September 26, 2025 21:47
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR increases the GitHub Actions workflow timeout from 90 minutes to 2 hours (120 minutes) to prevent workflows from timing out before completion. The change addresses timeout issues that have been occurring during CI/CD pipeline execution.

  • Increases timeout-minutes from 90 to 120 across all build jobs
  • Applies the change consistently to Linux, Windows, and macOS build environments
  • Provides additional buffer time for long-running build and test processes

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ReeceHumphreys ReeceHumphreys self-assigned this Sep 26, 2025
@ReeceHumphreys ReeceHumphreys marked this pull request as draft September 26, 2025 21:56
@Mark2000
Copy link
Contributor

Recommend against this because it’s caused by hanging, not tests taking too long.

@schaubh
Copy link
Contributor

schaubh commented Sep 27, 2025

I agree about not extending this, the Linux runs just hang. It is not a particular test. I have removed these tests where it appears to be hanging and then it just hangs at times at an earlier test. I would rather fail quicker and restart the test for now. Tedious, I know...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants