Refactor/refactor prescribed trans msg #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leahkiner
force-pushed
the
refactor/refactor-prescribedTransMsg
branch
from
a4a19d6 to
2cbd75f
Compare
leahkiner
force-pushed
the
refactor/refactor-prescribedTransMsg
branch
2 times, most recently
from
605d8ff to
66b6c23
Compare
The module's PrescribedTransMsgPayload message is replaced with the new LinearTranslationRigidBodyMsgPayload message
The unit test PrescribedTransMsgPayload message is replaced with the new LinearTranslationRigidBodyMsgPayload message
leahkiner
force-pushed
the
refactor/refactor-prescribedTransMsg
branch
from
66b6c23 to
3681485
Compare
patkenneally
approved these changes
Feb 12, 2024
leahkiner
force-pushed
the
refactor/refactor-prescribedTransMsg
branch
from
b0395de to
7f92b76
Compare
joaogvcarneiro
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a simple refactor to improve the clarity of the current
PrescribedTransMsgPayloadmessage. The name of this message is changed toLinearTranslationRigidBodyMsg, and the variablesscalarPosandscalarVelare changed torhoandrhoDot, respectively. Further, the new name of this message makes the use case for this message more clear; as before it appeared that this message was specific to prescribed motion (which it is not). This refactor is driven by the newPrescribedTranslationMsgPayloadthat will be added in a subsequent PR. Clarity is needed to distinguish these two messages.Verification
No additional verification is needed for this refactor
Documentation
No additional documentation is needed for this refactor
Future work
N/A