-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/817 mechanism for zeroing effector control alg msg outputs #943
Open
Natsoulas
wants to merge
3
commits into
develop
Choose a base branch
from
feature/817-mechanism-for-zeroing-effector-control-alg-msg-outputs
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature/817 mechanism for zeroing effector control alg msg outputs #943
Natsoulas
wants to merge
3
commits into
develop
from
feature/817-mechanism-for-zeroing-effector-control-alg-msg-outputs
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schaubh
requested changes
Feb 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting close, need to address a few small items. Shouldn't take long.
src/fswAlgorithms/effectorInterfaces/dipoleMapping/dipoleMapping.c
Outdated
Show resolved
Hide resolved
src/fswAlgorithms/effectorInterfaces/thrMomentumDumping/thrMomentumDumping.c
Outdated
Show resolved
Hide resolved
src/fswAlgorithms/effectorInterfaces/thrMomentumDumping/thrMomentumDumping.c
Outdated
Show resolved
Hide resolved
src/fswAlgorithms/effectorInterfaces/thrMomentumDumping/thrMomentumDumping.c
Outdated
Show resolved
Hide resolved
src/fswAlgorithms/effectorInterfaces/thrMomentumDumping/thrMomentumDumping.c
Outdated
Show resolved
Hide resolved
src/fswAlgorithms/effectorInterfaces/thrMomentumDumping/thrMomentumDumping.c
Outdated
Show resolved
Hide resolved
src/fswAlgorithms/effectorInterfaces/thrMomentumDumping/thrMomentumDumping.c
Outdated
Show resolved
Hide resolved
src/fswAlgorithms/effectorInterfaces/thrMomentumDumping/thrMomentumDumping.c
Outdated
Show resolved
Hide resolved
1ab549d
to
a04641f
Compare
a04641f
to
dbd386b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the issue of FSW algorithm modules failing to zero their output messages when disabled, which could lead to runaway operations. The approach taken was to review effector interface modules and implement consistent zeroing functionality in their reset methods.
The following modules were modified to zero their output messages in their
Reset
methods:rwMotorVoltage
torque2Dipole
dipoleMapping
forceTorqueThrForceMapping
torqueScheduler
thrusterPlatformReference
thrusterPlatformState
Each implementation follows the same pattern:
_zeroMsgPayload()
functionSome modules like
thrustRWDesat
were found to already have the necessary zeroing functionality in place.Verification
The changes were validated by:
Reset
method, which is called when modules are disabledNo new tests were added as this is a safety enhancement to existing functionality. The existing module tests will continue to validate the behavior of these modules.
Documentation
The release notes have been updated to include an entry about this enhancement.
The .rst documentation for all relevant effectors have been updated to mention the zeroing behavior on reset.
No other documentation was invalidated by these changes as they merely enhance existing functionality.
Future work
No immediate future work is anticipated. However, as new effector interface modules are added to the codebase, they should follow this pattern of zeroing output messages in their reset methods to maintain consistent safety behavior.