Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch bugs #192

Merged
merged 68 commits into from
Nov 5, 2019
Merged

Branch bugs #192

merged 68 commits into from
Nov 5, 2019

Conversation

chowyiyin
Copy link

@chowyiyin chowyiyin commented Nov 4, 2019

Validate age range (start age does not exceed end age & ages cannot go beyond 120) (#160)
Coverage 0 <= days <= 31, 0<= months <= 12, years >=0 (#173)
Fix merge bug (#170)
Update date of birth message (#148)

boolean isValidMonth = Integer.parseInt(months) >= 0 && Integer.parseInt(months) <= 12;
boolean isValidYear = Integer.parseInt(years) >= 0;
return isValidDay && isValidMonth && isValidYear;
} else {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix error message too.
Screenshot 2019-11-05 at 10 01 10 AM

@larrylawl larrylawl merged commit 368d337 into AY1920S1-CS2103-F09-4:master Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants