Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add set bin item expiry time functionality #196

Merged
merged 10 commits into from
Nov 7, 2019

Conversation

ybchen97
Copy link

@ybchen97 ybchen97 commented Nov 5, 2019

@chaitanyabaranwal
Copy link

One bug with the functionality is this:

  1. Set binitemexpiry to 60 seconds, delete a person.
  2. Change binitemexpiry to 30 days.
  3. Even though the bin expiry is internally changed to 30 days, on entering the command listbin, the expiry date for the contact still shows the date which delayed by 60 seconds.

@ybchen97 ybchen97 force-pushed the master branch 2 times, most recently from 3e39b1e to 47acd88 Compare November 6, 2019 17:50
@chaitanyabaranwal chaitanyabaranwal merged commit abe009e into AY1920S1-CS2103-F09-4:master Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants