Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] CS2101 User Guide #290

Merged
merged 14 commits into from
Nov 24, 2023

Conversation

samuelim01
Copy link

@samuelim01 samuelim01 commented Nov 14, 2023

Things to do:

  • Re-add the clear section of the tutorial
  • PDF-centric placement of Back to top
  • Remove duplicate tip for INDEX for guest edit and vendor edit
  • Use pic components to prevent clicking of images
  • Standardize references to other sections to lowercase (1.2, 4.5)
  • Reduce image size for 4.3. Filtering guests
  • Format Control, Command, Z and Y as code snippets
  • Shorten email constraints(?)
  • Space out contents page

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6a84f8b) 90.85% compared to head (59b11ad) 90.85%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #290   +/-   ##
=========================================
  Coverage     90.85%   90.85%           
  Complexity      832      832           
=========================================
  Files            97       97           
  Lines          2188     2188           
  Branches        305      305           
=========================================
  Hits           1988     1988           
  Misses          129      129           
  Partials         71       71           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

The images have hyperlinks that will link to 127.0.0.1:8080 if the UG is printed using `npm run serve`.

Let's use the pic component to prevent the pictures from having hyperlinks.
samuelim01 and others added 8 commits November 14, 2023 15:46
Add pic closing tag
Shrink pic width for filtering guests tutorial
Let's,
* Update page formatting to accommodate back to top at bottom of pages
* Change fields such as "unknown" to be written as `unknown`
* Crop and resize some screenshots
* Shortened some tips

Co-Authored-By: tllshan <105906799+tllshan@users.noreply.github.com>
@samuelim01
Copy link
Author

Based on the current modifications, this is the current state of the user guide:
CS2101_User_Guide.pdf

@samuelim01
Copy link
Author

Based on the current modifications, this is the current state of the user guide:
CS2101_User_Guide.pdf

Copy link
Member

@keaganpzh keaganpzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closed for completion

@keaganpzh keaganpzh merged commit a1a6831 into AY2324S1-CS2103T-F11-2:master Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants