Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update UI to display Organization and Recruiter information #37

Merged
merged 6 commits into from
Oct 17, 2023
Merged

Update UI to display Organization and Recruiter information #37

merged 6 commits into from
Oct 17, 2023

Conversation

wxwern
Copy link

@wxwern wxwern commented Oct 16, 2023

No description provided.

@wxwern wxwern added type.Enhancement Enhancement to an existing feature or user story (CS2103T label) priority.High Must do tasks (CS2103T label) labels Oct 16, 2023
@wxwern wxwern added this to the v1.2 milestone Oct 16, 2023
@wxwern wxwern requested review from a team, wamps-jp and CJ-Lee01 and removed request for a team October 16, 2023 14:32
@wxwern wxwern marked this pull request as ready for review October 17, 2023 08:26
@wxwern
Copy link
Author

wxwern commented Oct 17, 2023

As there's not yet a method to lookup contacts by id, the organization of a recruiter is only shown as the id and has no validation as per the current behavior.

@McNaBry McNaBry self-requested a review October 17, 2023 08:33
McNaBry
McNaBry approved these changes Oct 17, 2023
View reviewed changes
Copy link

@McNaBry McNaBry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI looks good to me. Basic add operations and storage function normally.

@wxwern wxwern enabled auto-merge October 17, 2023 08:45
wamps-jp
wamps-jp approved these changes Oct 17, 2023
View reviewed changes
Copy link

@wamps-jp wamps-jp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI changes look good!

@wxwern wxwern merged commit a03c6ba into AY2324S1-CS2103T-W08-3:master Oct 17, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wamps-jp wamps-jp wamps-jp approved these changes

@McNaBry McNaBry McNaBry approved these changes

@CJ-Lee01 CJ-Lee01 Awaiting requested review from CJ-Lee01 CJ-Lee01 was automatically assigned from AY2324S1-CS2103T-W08-3/team

Assignees
No one assigned
Labels
priority.High Must do tasks (CS2103T label) type.Enhancement Enhancement to an existing feature or user story (CS2103T label)
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.
3 participants
@wxwern @McNaBry @wamps-jp