Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Delete command UG, DG and messages #45

Merged
merged 6 commits into from
Oct 22, 2023
Merged

Update Delete command UG, DG and messages #45

merged 6 commits into from
Oct 22, 2023

Conversation

CJ-Lee01
Copy link

No description provided.

@CJ-Lee01 CJ-Lee01 requested review from a team, wxwern and tanshiyu1999 and removed request for a team October 19, 2023 07:51
@CJ-Lee01 CJ-Lee01 changed the title Update Delete command UG, DG and messages Update Delete command UG and messages Oct 19, 2023
@CJ-Lee01 CJ-Lee01 added type.Documentation Items related to or requiring documentation (custom label) priority.Medium Nice to have tasks (CS2103T label) labels Oct 19, 2023
tanshiyu1999
tanshiyu1999 approved these changes Oct 19, 2023
View reviewed changes
Copy link

@tanshiyu1999 tanshiyu1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete comment seems to have been updated properly as reflected in both UG and Error Message

@CJ-Lee01 CJ-Lee01 changed the title Update Delete command UG and messages Update Delete command UG, DG and messages Oct 20, 2023
@CJ-Lee01 CJ-Lee01 marked this pull request as ready for review October 20, 2023 06:44
@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #45 (612cb65) into master (d918ad5) will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master      #45      +/-   ##
============================================
+ Coverage     65.27%   65.29%   +0.01%     
- Complexity      521      522       +1     
============================================
  Files            83       83              
  Lines          1849     1850       +1     
  Branches        215      215              
============================================
+ Hits           1207     1208       +1     
  Misses          577      577              
  Partials         65       65
Files Coverage Δ
...va/seedu/address/logic/commands/DeleteCommand.java 69.23% <ø> (+0.80%) ⬆️

wxwern
wxwern approved these changes Oct 20, 2023
View reviewed changes
Copy link

@wxwern wxwern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. If you have no further planned changes in the future you can remove the {To be updated...} line.

@wxwern wxwern added this to the v1.3 milestone Oct 20, 2023
@wamps-jp wamps-jp merged commit 40f798a into AY2324S1-CS2103T-W08-3:master Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanshiyu1999 tanshiyu1999 tanshiyu1999 approved these changes

@wxwern wxwern wxwern approved these changes

Assignees
No one assigned
Labels
priority.Medium Nice to have tasks (CS2103T label) type.Documentation Items related to or requiring documentation (custom label)
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.
4 participants
@CJ-Lee01 @wxwern @tanshiyu1999 @wamps-jp