Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update app UI, default data and relevant docs #46

Merged
merged 6 commits into from
Oct 19, 2023
Merged

Update app UI, default data and relevant docs #46

merged 6 commits into from
Oct 19, 2023

Conversation

wxwern
Copy link

@wxwern wxwern commented Oct 19, 2023

No description provided.

@wxwern wxwern added this to the v1.2b milestone Oct 19, 2023
@wxwern wxwern added type.Documentation Items related to or requiring documentation (custom label) type.Enhancement Enhancement to an existing feature or user story (CS2103T label) priority.High Must do tasks (CS2103T label) labels Oct 19, 2023
@wxwern wxwern requested review from a team, McNaBry and wamps-jp and removed request for a team October 19, 2023 13:25
@wxwern wxwern marked this pull request as ready for review October 19, 2023 14:26
@wxwern wxwern enabled auto-merge October 19, 2023 14:26
McNaBry
McNaBry approved these changes Oct 19, 2023
View reviewed changes
Copy link

@McNaBry McNaBry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me. The UI screenshot is nice while the changes to displaying empty fields are good.

wamps-jp
wamps-jp approved these changes Oct 19, 2023
View reviewed changes
Copy link

@wamps-jp wamps-jp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good! The UI changes should help, and the sample contacts being changed to organizations and recruiters is consistent with the assumption that every contact added will be either an organization or a recruiter.

@wamps-jp wamps-jp self-requested a review October 19, 2023 16:26
@wxwern wxwern merged commit 7be2ab7 into AY2324S1-CS2103T-W08-3:master Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wamps-jp wamps-jp wamps-jp approved these changes

@McNaBry McNaBry McNaBry approved these changes

Assignees
No one assigned
Labels
priority.High Must do tasks (CS2103T label) type.Documentation Items related to or requiring documentation (custom label) type.Enhancement Enhancement to an existing feature or user story (CS2103T label)
Projects
None yet
Milestone
v1.2b
Development

Successfully merging this pull request may close these issues.
3 participants
@wxwern @McNaBry @wamps-jp