-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UC04 (Load) to the developer guide #24
Add UC04 (Load) to the developer guide #24
Conversation
The developer guide lacked information about loading contact data from a JSON file (UC04). This addition provides detailed steps for loading contact data and handling various scenarios such as missing or empty JSON files, and non-existent data folders. This change is made to ensure that developers have clear instructions on how the application loads contact data, including the handling of potential errors or missing files. This commit completes the coverage of contact data management in the developer guide, enhancing the documentation's comprehensiveness.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #24 +/- ##
=========================================
Coverage 75.26% 75.26%
Complexity 419 419
=========================================
Files 71 71
Lines 1338 1338
Branches 126 126
=========================================
Hits 1007 1007
Misses 301 301
Partials 30 30 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
The developer guide lacked information about loading contact data from a JSON file (UC04). This addition provides detailed steps for loading contact data and handling various scenarios such as missing or empty JSON files, and non-existent data folders.
This change is made to ensure that developers have clear instructions on how the application loads contact data, including the handling of potential errors or missing files.
This commit completes the coverage of contact data management in the developer guide, enhancing the documentation's comprehensiveness.