Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UC04 (Load) to the developer guide #24

Conversation

felixchanyy
Copy link
Collaborator

The developer guide lacked information about loading contact data from a JSON file (UC04). This addition provides detailed steps for loading contact data and handling various scenarios such as missing or empty JSON files, and non-existent data folders.

This change is made to ensure that developers have clear instructions on how the application loads contact data, including the handling of potential errors or missing files.

This commit completes the coverage of contact data management in the developer guide, enhancing the documentation's comprehensiveness.

The developer guide lacked information about loading contact data from
a JSON file (UC04). This addition provides detailed steps for
loading contact data and handling various scenarios such as missing
or empty JSON files, and non-existent data folders.

This change is made to ensure that developers have clear instructions
on how the application loads contact data, including the handling of
potential errors or missing files.

This commit completes the coverage of contact data management
in the developer guide, enhancing the documentation's comprehensiveness.
@felixchanyy felixchanyy added this to the v1.1 milestone Mar 6, 2024
@felixchanyy felixchanyy self-assigned this Mar 6, 2024
@felixchanyy felixchanyy linked an issue Mar 6, 2024 that may be closed by this pull request
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.26%. Comparing base (cb692f1) to head (7249322).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #24   +/-   ##
=========================================
  Coverage     75.26%   75.26%           
  Complexity      419      419           
=========================================
  Files            71       71           
  Lines          1338     1338           
  Branches        126      126           
=========================================
  Hits           1007     1007           
  Misses          301      301           
  Partials         30       30           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@KhoonSun47 KhoonSun47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@limcaaarl limcaaarl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felixchanyy felixchanyy merged commit 9868c64 into AY2324S2-CS2103-F09-1:master Mar 6, 2024
5 checks passed
Copy link
Collaborator

@zengzihui zengzihui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation US8
Projects
None yet
4 participants