-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 3 use case linking buyers to sellers, adding notes about clients and exit application to developer guide #29
Conversation
The developer guide lacks information about new use cases. To ensure that developers have comprehensive documentation about the system's functionality. Providing detailed use cases helps developers understand the system's behavior and functionality more effectively. The new use cases include linking buyers to sellers, adding notes about clients and exit application.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #29 +/- ##
=========================================
Coverage 75.26% 75.26%
Complexity 419 419
=========================================
Files 71 71
Lines 1338 1338
Branches 126 126
=========================================
Hits 1007 1007
Misses 301 301
Partials 30 30 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but if I am not wrong, maybe should omit the UI details when writing the use case, e.g. specified format: link [property_info] [buyer_id] [seller_id]
because the use case specification should be as general as possible (less specific) about the UI.
The use case specification should be as general as possible. Modify linking buyers to sellers and adding notes about clients use cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the inputs I commented below, I think it looks good. 👍
Helps to easy identify the use case Add UC06, UC07, UC08 and remove redundant statement in UC07
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The developer guide lacks information about new use cases. To ensure that developers have comprehensive documentation about the system's functionality.
Providing detailed use cases helps developers understand the system's behavior and functionality more effectively.
The new use cases include linking buyers to sellers, adding notes about clients and exit application.