Add Unit Number #59
Merged
Add Unit Number #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update CLISyntax.java: Add prefix for unit number Add UnitNumber.java: Add functionality to add unit number to add command Add UnitNumberTest.java: Add test cases to test UnitNumber.java
Update UnitNumberTest.java: Remove two test cases
KhoonSun47
requested review from
limcaaarl,
redcolorbicycle,
zengzihui and
felixchanyy
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #59 +/- ##
============================================
+ Coverage 75.79% 76.20% +0.40%
- Complexity 431 450 +19
============================================
Files 72 74 +2
Lines 1376 1416 +40
Branches 131 135 +4
============================================
+ Hits 1043 1079 +36
- Misses 303 307 +4
Partials 30 30 ☔ View full report in Codecov by Sentry. |
Update UnitNumber.java: Change the requirement such that unit number must be at least 1 digit, and at most 3 digits (but cannot be 0) Update UnitNumberTest.java: Change the test cases according to the new requirements
Update UnitNumber.java: Add another regex to test for the following input '0', '00', '000', which should be invalid since a unit number cannot be '0's Update UnitNumberTest.java: Update the test cases according to the new requirements
Update ParserUtil.java: Add parsing of unit numbers Update ParserUtilTest.java: Add test cases for parsing of unit numbers
felixchanyy
reviewed
Mar 16, 2024
| @@ -11,6 +11,7 @@ public class CliSyntax { | |||
| public static final Prefix PREFIX_EMAIL = new Prefix("e/"); | |||
| public static final Prefix PREFIX_ADDRESS = new Prefix("a/"); | |||
| public static final Prefix PREFIX_TAG = new Prefix("t/"); | |||
| public static final Prefix PREFIX_UNITNUMBER = new Prefix("unitNo/"); | |||
There was a problem hiding this comment.
Should this be formatted like 'u/' to maintain consistency with the rest of the syntax?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update CLISyntax.java: Add prefix for unit number
Add UnitNumber.java: Add functionality to add unit number to add command
Add UnitNumberTest.java: Add test cases to test UnitNumber.java