Create Seller and Buyer classes with add commands and test cases #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, there are no specific classes for representing sellers and buyers in the address book application. To differentiate between sellers and buyers in the address book application and to allow for specific functionalities and attributes for each. Two new classes, Seller and Buyer, are created as subclasses of the Person class. Each class has its own add command and test cases to ensure proper functionality. Subclassing from the Person class allows for code reuse and maintains consistency in the application's design. Separate classes enable distinct behavior and attributes for sellers and buyers. The new classes adhere to the existing design patterns and principles in the address book application. Tests cover various scenarios to ensure the correctness of the implementations.
felixchanyy
requested review from
limcaaarl,
redcolorbicycle,
zengzihui and
KhoonSun47
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #60 +/- ##
============================================
- Coverage 76.57% 72.97% -3.61%
- Complexity 466 468 +2
============================================
Files 76 82 +6
Lines 1456 1532 +76
Branches 139 147 +8
============================================
+ Hits 1115 1118 +3
- Misses 311 383 +72
- Partials 30 31 +1 ☔ View full report in Codecov by Sentry. |
redcolorbicycle
approved these changes
Mar 18, 2024
felixchanyy
merged commit 40ab66c
into
AY2324S2-CS2103-F09-1:master
3 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there are no specific classes for representing sellers and buyers in the address book application.
To differentiate between sellers and buyers in the address book application and to allow for specific functionalities and attributes for each.
Two new classes, Seller and Buyer, are created as subclasses of the Person class. Each class has its own add command and test cases to ensure proper functionality.
Subclassing from the Person class allows for code reuse and maintains consistency in the application's design.
Separate classes enable distinct behavior and attributes for sellers and buyers.
The new classes adhere to the existing design patterns and principles in the address book application. Tests cover various scenarios to ensure the correctness of the implementations.