Skip to content

Add Class Level, UnitNumber, and link PostalCode and Street to Seller #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 22, 2024

Conversation

felixchanyy
Copy link
Collaborator

Fixes inconsistency in Seller class attributes by introducing Level and
UnitNumber. Connect PostalCode and Street attributes to Seller
class for comprehensive address representation.

This change ensures that all necessary address-related
attributes are present in the Seller class, enhancing the
completeness and accuracy of seller information.

The decision to link PostalCode and Street directly to the
Seller class is made to streamline the representation of a
seller's address. By including these attributes within the Seller class,
we create a more cohesive and organized data structure, simplifying
access and manipulation of seller information.

No further relevant information at this time.

Fixes inconsistency in Seller class attributes by introducing Level and
UnitNumber. Connect PostalCode and Street attributes to Seller
class for comprehensive address representation.

This change ensures that all necessary address-related
attributes are present in the Seller class, enhancing the
completeness and accuracy of seller information.

The decision to link PostalCode and Street directly to the
Seller class is made to streamline the representation of a
seller's address. By including these attributes within the Seller class,
we create a more cohesive and organized data structure, simplifying
access and manipulation of seller information.

No further relevant information at this time.
@felixchanyy felixchanyy added the enhancement New feature or request label Mar 22, 2024
@felixchanyy felixchanyy self-assigned this Mar 22, 2024
Copy link
Collaborator

@zengzihui zengzihui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@redcolorbicycle redcolorbicycle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 😩

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.51%. Comparing base (96d24f1) to head (35a4882).
Report is 58 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #71   +/-   ##
=========================================
  Coverage     70.51%   70.51%           
  Complexity      482      482           
=========================================
  Files            87       87           
  Lines          1662     1662           
  Branches        160      160           
=========================================
  Hits           1172     1172           
  Misses          443      443           
  Partials         47       47           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@felixchanyy felixchanyy merged commit 5aa3f2c into AY2324S2-CS2103-F09-1:master Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants