Branch-Add-Json #76
Merged
Branch-Add-Json #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 'master' of https://github.com/KhoonSun47/tp: Update PUML Update UML diagram
* master: Update PUML Update UML diagram Update puml diagram Update puml for class diagram Add Class Level, UnitNumber, and link PostalCode and Street to Seller Add classes Buyer, Seller, PostalCode and Street. Buyer and Seller extend Person.
Add functionality to load data and add data to the addressbook Messages.java: Edit comment AddBuyerCommand.java, AddSellerCommand.java: Edit comment AddBuyerCommandParser: Update Person person to Buyer buyer House.java, Landed.java, Non-landed.java: Update toString() SampleDataUtil.java: Update sample datas to work with new JsonSerializableAddressBook JsonAdaptedHouse.java: Update to check for invalid field JsonSerializableAddressBook: Update methods to add buyer, toModelType will arrange data in alphabetical order PersonCard.java: Update method to display houses, buyer and seller duplicatePersonAddressBook, invalidPersonAddressBook, typicalPersonAddressBook: Update json to include buyer JsonAdaptedBuyerTest: Add test cases to test JsonAdaptedBuyer JsonAdaptedHouseTest: Update test cases to test for invalid field JsonSerializableAddressBookTest: Add test case to test for alphabetical order in list TypicalPerson: Add buyers to test new test cases that involves buyers
KhoonSun47
requested review from
limcaaarl,
redcolorbicycle,
zengzihui and
felixchanyy
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #76 +/- ##
============================================
+ Coverage 70.51% 72.43% +1.92%
- Complexity 482 501 +19
============================================
Files 87 86 -1
Lines 1662 1698 +36
Branches 160 173 +13
============================================
+ Hits 1172 1230 +58
+ Misses 443 422 -21
+ Partials 47 46 -1 ☔ View full report in Codecov by Sentry. |
limcaaarl
reviewed
Mar 27, 2024
| .withPhone("82937163").withEmail("ali@gmail.com").withHousingType("HDB").withTags("friends").build(); | ||
| public static final Person BEN = new BuyerBuilder().withName(VALID_NAME_BEN).withPhone(VALID_PHONE_BOB) | ||
| public static final Buyer BEN = new BuyerBuilder().withName(VALID_NAME_BEN).withPhone(VALID_PHONE_BOB) |
There was a problem hiding this comment.
Not really an issue, but you can consider following your previous variables names. (eg; BEN_BUYER)
There was a problem hiding this comment.
Yeap, I will take note of this
felixchanyy
merged commit 0658640
into
AY2324S2-CS2103-F09-1:master
4 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Case 8: Add Data and Load Data from Json
Changes made:
in alphabetical order