Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Developer Guide: Update the Person Role Implementation #236

Merged

Conversation

purivirakarin
Copy link
Collaborator

@purivirakarin purivirakarin commented Apr 15, 2024

Update the Design Consideration for Person Role Feature

@purivirakarin purivirakarin added this to the v1.4 milestone Apr 15, 2024
@purivirakarin purivirakarin requested a review from a team April 15, 2024 14:55
@purivirakarin purivirakarin self-assigned this Apr 15, 2024
Copy link
Collaborator

@shaunlxw shaunlxw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainly LGTM! Just some consistency in formatting, either use ordered list here, or change to unordered list in the delete section.

docs/DeveloperGuide.md Outdated Show resolved Hide resolved
Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.37%. Comparing base (dc201d3) to head (b05b4bd).
Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #236   +/-   ##
=========================================
  Coverage     79.37%   79.37%           
  Complexity      922      922           
=========================================
  Files           105      105           
  Lines          2763     2763           
  Branches        372      372           
=========================================
  Hits           2193     2193           
  Misses          474      474           
  Partials         96       96           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@shaunlxw shaunlxw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can consider removing the list completely for export feature.

docs/DeveloperGuide.md Show resolved Hide resolved
@purivirakarin purivirakarin merged commit 672b06f into AY2324S2-CS2103T-F12-1:master Apr 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants