Add PUML Implementation Diagram for Command History #292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
belligerentbeagle
added
docs
belligerentbeagle
requested review from
tituschewxj,
Anant1902,
wxiaoyun and
saiutkarsh33
|
Closes #246 |
wxiaoyun
approved these changes
Apr 13, 2024
Comment on lines
24
to
26
| ModelCH -> ModelCH : | ||
| ModelCH -> ModelCH : | ||
| ModelCH -> ModelCH : |
There was a problem hiding this comment.
I am not sure on this, but if we are not labelling the arrows, is it better to leave them out? (actual question)
There was a problem hiding this comment.
its okay to have internally pointed arrows without labels afaik, it also shows internal processes. But in hindsight, I realise sb who may not know this may mark us down for it and since a long activation bar also means internal processes, i will just remove it. Thanks for this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshot of added change!