Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ug labelled screenshots #293

Merged

Conversation

saiutkarsh33
Copy link

No description provided.

@saiutkarsh33 saiutkarsh33 self-assigned this Apr 13, 2024
@saiutkarsh33 saiutkarsh33 added the docs Improvements or additions to documentation label Apr 13, 2024
Copy link
Member

@tituschewxj tituschewxj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the images. I have some nits. Also please pull the latest version of our codebase, as the UG is out of date here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please pull the latest version of the UserGuide, as there are many new changes missing here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pulled, using git pull upstream master,
Says already up to date

Copy link
Member

@tituschewxj tituschewxj Apr 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you rebase your changes onto this branch?

git switch ug-screenshots
git rebase master

Or did you not push your changes?

git push

docs/images/ug-screenshots/addstu_after.png Show resolved Hide resolved
docs/images/ug-screenshots/delstu_after.png Show resolved Hide resolved
docs/images/ug-screenshots/find_after.png Show resolved Hide resolved
docs/images/ug-screenshots/mark_after.png Show resolved Hide resolved
docs/images/ug-screenshots/mark_before.png Show resolved Hide resolved
docs/images/ug-screenshots/unmark_after.png Show resolved Hide resolved
docs/images/ug-screenshots/unmark_before.png Show resolved Hide resolved
docs/images/ug-screenshots/launch.png Show resolved Hide resolved
docs/images/ug-screenshots/launch.png Show resolved Hide resolved
Copy link
Member

@tituschewxj tituschewxj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tituschewxj tituschewxj merged commit 3680d61 into AY2324S2-CS2103T-F13-1:master Apr 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants