Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update autocomplete diagrams #300

Merged
merged 2 commits into from
Apr 15, 2024
Merged

docs: Update autocomplete diagrams #300

merged 2 commits into from
Apr 15, 2024

Conversation

tituschewxj
Copy link
Member

@tituschewxj tituschewxj commented Apr 14, 2024 •
edited
Loading

image
image
image
image
image
image
image

Modified this because the previous image was too messy:
image

Resolves #226, resolves #245

@tituschewxj tituschewxj added the type.dg Developer Guide label Apr 14, 2024
@tituschewxj tituschewxj added this to the v1.4 milestone Apr 14, 2024
@tituschewxj tituschewxj requested a review from wxiaoyun April 14, 2024 10:31
@tituschewxj tituschewxj self-assigned this Apr 14, 2024
@tituschewxj tituschewxj added the size.medium Formidable sized pr, less than 500 lines of code changed label Apr 14, 2024
belligerentbeagle
belligerentbeagle approved these changes Apr 14, 2024
View reviewed changes
Copy link

@belligerentbeagle belligerentbeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for working on this, and thought you had good use of reference frames for the diagrams!

@tituschewxj tituschewxj merged commit 28fba86 into AY2324S2-CS2103T-F13-1:master Apr 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@belligerentbeagle belligerentbeagle belligerentbeagle approved these changes

@wxiaoyun wxiaoyun Awaiting requested review from wxiaoyun

@Anant1902 Anant1902 Awaiting requested review from Anant1902

@saiutkarsh33 saiutkarsh33 Awaiting requested review from saiutkarsh33

Assignees

@tituschewxj tituschewxj

Labels
size.medium Formidable sized pr, less than 500 lines of code changed type.dg Developer Guide
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

DG: autocomplete feature implementation Update DG with autocomplete refactor
2 participants
@tituschewxj @belligerentbeagle