Skip to content

docs: add screenshots to user guide #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 15, 2024
Merged

docs: add screenshots to user guide #310

merged 5 commits into from
Apr 15, 2024

Conversation

wxiaoyun
Copy link

@wxiaoyun wxiaoyun commented Apr 15, 2024 •
edited
Loading

Description

Problems

  • Screenshots do not have transparent background, and the pictures stand out from box component. See the grey bar circled in the screenshot:
    image
  • Fringes are not cropped out in the screenshot:
    image
  • Inconsistent font size (across screenshots)

@wxiaoyun wxiaoyun added docs Improvements or additions to documentation priority.high !!! size.small Short pr, less than 100 lines of code changed type.ug User guide labels Apr 15, 2024
@wxiaoyun wxiaoyun self-assigned this Apr 15, 2024
@wxiaoyun wxiaoyun marked this pull request as draft April 15, 2024 01:23
@wxiaoyun wxiaoyun added size.medium Formidable sized pr, less than 500 lines of code changed and removed size.small Short pr, less than 100 lines of code changed labels Apr 15, 2024
@wxiaoyun wxiaoyun marked this pull request as ready for review April 15, 2024 01:44
@wxiaoyun wxiaoyun force-pushed the ug-add-screenshots branch from 4d0df32 to 03e3a0b Compare April 15, 2024 02:53
@wxiaoyun wxiaoyun added this to the v1.4 milestone Apr 15, 2024
saiutkarsh33
saiutkarsh33 approved these changes Apr 15, 2024
View reviewed changes
Copy link

@saiutkarsh33 saiutkarsh33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saiutkarsh33 saiutkarsh33 merged commit fb84526 into AY2324S2-CS2103T-F13-1:master Apr 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saiutkarsh33 saiutkarsh33 saiutkarsh33 approved these changes

@belligerentbeagle belligerentbeagle Awaiting requested review from belligerentbeagle

@tituschewxj tituschewxj Awaiting requested review from tituschewxj

@Anant1902 Anant1902 Awaiting requested review from Anant1902

Assignees

@wxiaoyun wxiaoyun

Labels
docs Improvements or additions to documentation priority.high !!! size.medium Formidable sized pr, less than 500 lines of code changed type.ug User guide
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.
2 participants
@wxiaoyun @saiutkarsh33