Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: initialise specs from primitives #603

Merged
merged 38 commits into from
Sep 3, 2024
Merged

feat: initialise specs from primitives #603

merged 38 commits into from
Sep 3, 2024

Conversation

MartinBernstorff
Copy link
Collaborator

@MartinBernstorff MartinBernstorff commented Aug 30, 2024 •
edited
Loading

Turns out the installation was pinned to polars==0.19.0 due to skimpy having it as an upper bound. Issue here: aeturrell/skimpy#816

Have now switched to uv so we can override it, and fixed the issues there were due to breaking changes in polars' API. Sorry about the mixed PR.

Also added initialisation of specs from primitives.

Hope you like it @HLasse!

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Aug 30, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #603 will not alter performance

Comparing initialise_specs_from_primitives (95608f3) with main (2d3d7ba)

Summary

✅ 7 untouched benchmarks

@MartinBernstorff
update 5 files
b652623
@MartinBernstorff
update 5 files
e245b8a
@MartinBernstorff
update outcome.py
32387fd
@MartinBernstorff
update temporal.py
431463d
@MartinBernstorff
build(deps): update Dockerfile, 01_basic.ipynb and pyproject.toml
6cf5078
@MartinBernstorff
update Dockerfile and aggregators.py
84c008a
@MartinBernstorff
build: update Dockerfile
d55c2eb
@MartinBernstorff
build: update Dockerfile
9cc48d5
@MartinBernstorff
docs: update 01_basic.ipynb
2dac3fd
@MartinBernstorff
build(deps): update action.yml, 01_basic.ipynb, pyproject.toml and uv…
52a11aa 
….lock
@MartinBernstorff
build(deps): update pyproject.toml and uv.lock
a63f636
@MartinBernstorff
update devcontainer.json and post-start.sh
d317a64
@MartinBernstorff
update 7 files
584d31c
@MartinBernstorff
update post-start.sh and Dockerfile
3dddca6
@MartinBernstorff
update 5 files update 5 files update post-start.sh, Makefile and task…
77ba032 
…s.py
@MartinBernstorff
chore: update action.yml
02fc722
@MartinBernstorff
update action.yml, static_type_checks.yml and Makefile
8ad9ef7
@MartinBernstorff
build: update Makefile
a2b5438
@MartinBernstorff
build: update Dockerfile
35deb50
@MartinBernstorff
docs: update 03_text.ipynb
aa780c1
HLasse
HLasse reviewed Sep 2, 2024
View reviewed changes
src/timeseriesflattener/specs/timedelta.py Outdated Show resolved Hide resolved
src/timeseriesflattener/specs/__init__.py Outdated Show resolved Hide resolved
HLasse
HLasse approved these changes Sep 2, 2024
View reviewed changes
Copy link
Collaborator

@HLasse HLasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, Martin! I look forward to trying out uv as well!

@HLasse HLasse merged commit 057a1a9 into main Sep 3, 2024
13 checks passed
@HLasse HLasse deleted the initialise_specs_from_primitives branch September 3, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HLasse HLasse HLasse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MartinBernstorff @HLasse