Skip to content

Comments

feat: Build for Windows(x86_64), Linux(x86_64), MacOS(arm64) in GitHub hosted Runners#1

Draft
ZhiFenBL wants to merge 9 commits intoAaronBenDaniel:mainfrom
ZhiFenBL:main
Draft

feat: Build for Windows(x86_64), Linux(x86_64), MacOS(arm64) in GitHub hosted Runners#1
ZhiFenBL wants to merge 9 commits intoAaronBenDaniel:mainfrom
ZhiFenBL:main

Conversation

@ZhiFenBL
Copy link

@ZhiFenBL ZhiFenBL commented Jul 25, 2025

Adds actions workflow to build application with pyinstaller with options

  • bool: Build as a single executable file (--onefile)

    • true: slow application startup
    • false: faster startup
    • default: true
  • bool: Disable UPX compression for faster startup (--noupx)

    • true: faster startup
    • false: smaller file size but slow startup
    • default: false
  • bool: Hide the console window (GUI mode)

    • true: No cli opens on execution.
    • false: A cli is attached.
    • default: true

@ZhiFenBL ZhiFenBL marked this pull request as draft July 25, 2025 13:25
@AaronBenDaniel AaronBenDaniel marked this pull request as ready for review July 27, 2025 18:17
Copy link
Owner

@AaronBenDaniel AaronBenDaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I like this, but, if possible, I'd rather not add pyinstaller to requirements.txt, as pyinstaller is only used if a user is compiling an executable and does not use it when running with Python.

@ZhiFenBL
Copy link
Author

I've changed it but the reason I made this a draft is, I'm getting strange errors.

For ex: https://github.com/ZhiFenBL/Wattpad_Downloader/actions/runs/16557603799 - cannot download

So this should remain a draft for now.

@ZhiFenBL ZhiFenBL marked this pull request as draft July 28, 2025 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants