-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Trending Memes Sidebar #112
Conversation
<button | ||
key={index} | ||
onClick={() => handleTagClick(suggestion)} | ||
className="bg-gray-200 text-black rounded-full px-4 py-1 text-lg focus:outline-none " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we make the text-lg to text-md. It looks really large.
|
||
return ( | ||
<aside className="hidden lg:block w-1/4 bg-white p-2 sticky top-0 h-screen overflow-y-auto border-l border-gray-200 z-40 "> | ||
<h2 className="text-2xl font-bold text-center pt-14 text-gray-900 mb-4 "> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the pt-14 looks very weird once the header bar is hidden. It makes it look really out of place.
Either make it responsive by attaching it with header bar so that when header bar appears, it shifts down and when header bar disappears, it shifts up.
OR
detach it from top of screen and it it a little lower so it looks like it is intentionally placed there.
One similar idea is to have a side section be completely seperate from header bar and make the header bar operate only in the feed area. Just like we have a section on the left side for category, we can have another section on the right for the widgets. Something like primal.net does on their website. What are your thoughts on this?
No description provided.