Skip to content

Commit

Permalink
Merge pull request #469 from Ableton/nre/main/jenkins-ruleset
Browse files Browse the repository at this point in the history
Use the new Jenkins ruleset
  • Loading branch information
nre-ableton authored Sep 3, 2024
2 parents 35ee035 + 4c30566 commit 46f08cd
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 5 deletions.
4 changes: 2 additions & 2 deletions Jenkinsfile
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ devToolsProject.run(
data['venv'] = pyenv.createVirtualEnv(readFile('.python-version'))
data.venv.run('pip install -r requirements-dev.txt')

data['groovy3Version'] = '3.0.10'
data['groovy4Version'] = '4.0.2'
data['groovy3Version'] = '3.0.22'
data['groovy4Version'] = '4.0.22'

[data.groovy3Version, data.groovy4Version].each { groovyVersion ->
String groovyZip = "apache-groovy-binary-${groovyVersion}.zip"
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@ This repository provides a way to run [CodeNarc][codenarc-home] checks from a do
image. CodeNarc analyzes Groovy code for defects, bad practices, inconsistencies, style
issues and more.

CodeNarc, and Groovylint by extension, require Groovy 3.0 or greater.
CodeNarc, and Groovylint by extension, require Groovy 3.0.22 or greater (or Groovy 4.0.11
or greater, if using Groovy 4.x).

## Usage

Expand Down Expand Up @@ -48,7 +49,6 @@ $ docker run --rm -v `pwd`:/ws -u `id -u`:`id -g` abletonag/groovylint \
/opt/run_codenarc.py --single-file Jenkinsfile
```


### Running in a Docker container

```bash
Expand Down
2 changes: 1 addition & 1 deletion VERSION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
0.14.6
0.15.0
1 change: 1 addition & 0 deletions ruleset.groovy
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ ruleset {
ruleset('rulesets/generic.xml') {}
ruleset('rulesets/groovyism.xml') {}
ruleset('rulesets/imports.xml') {}
ruleset('rulesets/jenkins.xml') {}
ruleset('rulesets/naming.xml') {
FactoryMethodName(enabled: false)
VariableName(ignoreVariableNames: '_')
Expand Down

0 comments on commit 46f08cd

Please sign in to comment.