Use pull_request
instead of pull_request_target
#49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the GitHub Action trigger from
pull_request_target
topull_request
.pull_request_target
seemed to be recommended for working with forks as laid out in this article:However this has had the effect that for PRs coming from a branch of this repository as opposed to a forked repository, tests ran on the base of the PR instead of taking the changes of the PR into account:
This explains why it was possible to merge PR #45 while the tests failed after the merge.
The effect this PR has on PRs coming from forks is not clear at this time but since that happens rarely we accept to address that once we run into actual issues in that scenario.