Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/interchain core #503

Merged
merged 13 commits into from
Oct 8, 2024
Merged

Refactor/interchain core #503

merged 13 commits into from
Oct 8, 2024

Conversation

Kayanski
Copy link
Contributor

This PR aims at refactoring interchain-core by providing better types and abstractions, namely brings a separation between results (following the packet flow) and analysis (making sure there is no timeout and no ack errors).

TODO (maybe in another PR)
--> Add the possibility to error on error during acknowledgement execution

Checklist

  • Changelog updated.
  • Docs updated.

Copy link

cloudflare-workers-and-pages bot commented Sep 30, 2024

Deploying cw-orchestrator with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0328084
Status:⚡️  Build in progress...

View logs

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 15.36232% with 292 lines in your changes missing coverage. Please review.

Project coverage is 55.7%. Comparing base (0577cd3) to head (0328084).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/interchain/interchain-core/src/packet.rs 0.0% 157 Missing ⚠️
...ackages/interchain/interchain-core/src/analysis.rs 22.1% 74 Missing ⚠️
packages/interchain/interchain-core/src/tx.rs 24.1% 22 Missing ⚠️
...kages/interchain/interchain-core/src/ack_parser.rs 40.0% 15 Missing ⚠️
...terchain/interchain-daemon/src/packet_inspector.rs 0.0% 14 Missing ⚠️
...ckages/interchain/interchain-core/src/ibc_query.rs 40.0% 6 Missing ⚠️
...interchain/interchain-daemon/src/interchain_env.rs 0.0% 3 Missing ⚠️
packages/interchain/proto/src/tokenfactory.rs 0.0% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
packages/interchain/interchain-core/src/channel.rs 56.6% <ø> (ø)
packages/interchain/interchain-core/src/env.rs 92.1% <100.0%> (+21.4%) ⬆️
packages/interchain/interchain-daemon/src/error.rs 0.0% <ø> (ø)
...kages/interchain/interchain-mock/src/interchain.rs 85.4% <100.0%> (-1.0%) ⬇️
packages/interchain/proto/src/tokenfactory.rs 0.0% <0.0%> (ø)
...interchain/interchain-daemon/src/interchain_env.rs 0.0% <0.0%> (ø)
...ckages/interchain/interchain-core/src/ibc_query.rs 40.0% <40.0%> (ø)
...terchain/interchain-daemon/src/packet_inspector.rs 0.0% <0.0%> (ø)
...kages/interchain/interchain-core/src/ack_parser.rs 33.3% <40.0%> (+11.9%) ⬆️
packages/interchain/interchain-core/src/tx.rs 24.1% <24.1%> (ø)
... and 2 more

Copy link
Contributor

@CyberHoward CyberHoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments on naming

packages/interchain/interchain-core/src/packet.rs Outdated Show resolved Hide resolved
packages/interchain/interchain-core/src/packet.rs Outdated Show resolved Hide resolved
packages/interchain/interchain-core/src/packet.rs Outdated Show resolved Hide resolved
@Kayanski Kayanski merged commit b9f0957 into main Oct 8, 2024
11 of 12 checks passed
@Kayanski Kayanski deleted the refactor/interchain-core branch October 8, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants