Skip to content

PR: ACES 2.0 #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Mar 14, 2025
Merged

PR: ACES 2.0 #130

merged 16 commits into from
Mar 14, 2025

Conversation

KelSolaar
Copy link
Contributor

@KelSolaar KelSolaar commented Aug 3, 2024 •
edited
Loading

@KelSolaar KelSolaar force-pushed the feature/aces-2.0 branch 2 times, most recently from 94ddacb to c4f7ea4 Compare August 5, 2024 19:31
@KelSolaar KelSolaar force-pushed the feature/aces-2.0 branch 7 times, most recently from c84d3e3 to 53dd1a0 Compare August 31, 2024 20:55
@KelSolaar
Copy link
Contributor Author

First artifacts are here: https://github.com/AcademySoftwareFoundation/OpenColorIO-Config-ACES/actions/runs/10648206791

I haven't checked anything yet.

@carolalynn
Copy link

Amazing Thomas - just want to note a few quick things:

CG Config:

  • We had a few more views / displays in previous versions:
    • PQ P3 1000 nit Rec. 2020 lim
    • PQ P3 1000 nit P3 lim
    • SDR Cinema

Studio config:

  • Name of look transforms seem off, the gamut compression is named "ACES2065-1"
  • Did we decide to split the D65 / D60 into two configs?

General:

  • talk about "extended" displays for Display P3 etc? Might want these in both configs.
  • will do a more detailed naming/alias check later once CIF decides on names

@KelSolaar KelSolaar force-pushed the feature/aces-2.0 branch 3 times, most recently from 1aef3a0 to 573f739 Compare September 27, 2024 23:57
@doug-walker
Copy link
Contributor

I added three of the missing display built-in transforms to your spreadsheet (only one still missing).

Looking at the color spaces, I'm noticing both "Apple Log" and "AppleLog BT2020", despite the latter not being in the spreadsheet.

@KelSolaar
Copy link
Contributor Author

I implemented support for:

  • Passing the encoding as a suffix to the DisplayColorspace name
  • Excluding the D60 views although we need to discuss how we want to name the Configs

@doug-walker
Copy link
Contributor

@KelSolaar , thanks for adding the ability to have an SDR and HDR version of DisplayP3! Here are some comments looking at the most recent Studio config artifact:

  • I like your use of the "SDR - Display" and "HDR - Display" suffixes on DisplayP3. However, I'm wondering if some people will complain that some display names indicate range and others don't. An alternative would be to leave the SDR displays as "Display" and change all the HDR displays to "HDR Display". But on the other hand, indicating the range on just those displays that have both could be considered a benefit. Minor point, but do we need the second dash, perhaps "Display P3 - HDR Display" would be sufficient?
  • If we do use the proposed "Display P3 - SDR - Display" name, we should add the previous name and "displayp3_display" aliases for backwards compatibility.
  • It looks like for all the HDR displays, we are include the SDR ACES views, to have them available for soft-proofing. So it's expected to see the SDR displays in the HDR version. However, please remove the HDR views from the SDR display.
  • This config continues to have both the D65 and D60 views (I guess the new option to remove D60 was not in effect?). However, the Display P3 views are a strange and incomplete mix of D60 and D65.
  • Both display color spaces have the same set of ACEStransformIDs. Not sure what to do here. Probably we should only include the SDR views with the SDR display, and HDR views with the HDR display. But just wondering if there would be scenarios where it's safer to have all of them?

@doug-walker
Copy link
Contributor

doug-walker commented Nov 4, 2024 •
edited
Loading

I had an action-item from the last meeting to check the ACES v2 config to see if we have all the color spaces from the ACES v1.3 configs. Here are my findings:

  • For the named_transforms, "ARRI LogC3 - Curve (EI800)" is missing.
  • All scene-referred color spaces are present.
  • For the display-referred color spaces, the displays that are not included in the ACES v2 set are missing, these are: "Rec.1886 Rec.2020 - Display", "P3-D60 - Display", and "P3-DCI - Display".
  • There are a lot of aliases that are missing. I guess we should discuss whether we want to include all of them, or use this as an opportunity to prune some of the older ones.

Not sure what to do about the displays. On the one hand, they are not very relevant and I'm open to dropping them. On the other hand, I'm just wondering if anyone will complain about missing displays when moving from ACES v1 to v2.

@KelSolaar
Copy link
Contributor Author

KelSolaar commented Nov 12, 2024 •
edited
Loading

Hello,

Thanks for the thorough review!

1

Minor point, but do we need the second dash, perhaps "Display P3 - HDR Display" would be sufficient?

The second dash is coming from the - Display suffix that we consistently add to all the display colourspaces. It feels a bit arbitrary to add that to Display P3 when none of the other HDR display has it. What about Display P3 SDR - Display and Display P3 HDR - Display?

2

If we do use the proposed "Display P3 - SDR - Display" name, we should add the previous name and "displayp3_display" aliases for backwards compatibility.

Yes, good catch!

3

It looks like for all the HDR displays, we are include the SDR ACES views, to have them available for soft-proofing. So it's expected to see the SDR displays in the HDR version. However, please remove the HDR views from the SDR display.

Where did you see this? The only instances I saw are occurring for Display P3 which is "expected" because we use the same builtin for both HDR and SDR. It would be much cleaner to have a dedicated Display P3 HDR builtin as suggested in previous meetings:

  • I would not need to use that new gross encoding column that we added for Display P3
  • The generator would work perfectly fine as it was intended

I'm happy to make a PR for this on the OCIO side.

4

I guess the new option to remove D60 was not in effect?

Yes, I will check what happened for Display P3, maybe the quick filterer I wrote is not "smart" enough or there are yet another problem because we introduced that special case as mentioned earlier.

5

Both display color spaces have the same set of ACEStransformIDs. Not sure what to do here.

It might be time to source this AMF data from the ACES side and stop generating it on our end.

6

For the named_transforms, "ARRI LogC3 - Curve (EI800)" is missing.

I will check, it might not even be in the spreadsheet.

7

the displays that are not included in the ACES v2 set are missing

If they are not in ACES 2.0, they cannot be in the config at the moment.

8

There are a lot of aliases that are missing.

If you have a list we could talk about it yep!

@doug-walker
Copy link
Contributor

@KelSolaar , I looked again at the alias differences I reported above and found a bug in my comparison script. The changes needed are actually very minimal. Please simply add "lin_ap1_scene" to ACEScg.

@doug-walker
Copy link
Contributor

@KelSolaar , if you would like to add the additional DisplayP3 HDR built-in, you would make a second call to registry.addBuiltin here.

Suggested name: "DISPLAY - CIE-XYZ-D65_to_DisplayP3-HDR", but I'm flexible.

KelSolaar added a commit to colour-science/OpenColorIO that referenced this pull request Nov 16, 2024
@KelSolaar
Add DISPLAY - CIE-XYZ-D65_to_DisplayP3-HDR builtin transform.
10adaf3 
References AcademySoftwareFoundation/OpenColorIO-Config-ACES#130

Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>
@KelSolaar KelSolaar mentioned this pull request Nov 16, 2024
Merged
KelSolaar added a commit to colour-science/OpenColorIO that referenced this pull request Nov 16, 2024
@KelSolaar
Add DISPLAY - CIE-XYZ-D65_to_DisplayP3-HDR builtin transform.
16948ca 
References AcademySoftwareFoundation/OpenColorIO-Config-ACES#130

Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>
@KelSolaar
Copy link
Contributor Author

OP updated with the latest config artifacts!

@BrewTestBot BrewTestBot mentioned this pull request Dec 12, 2024
Merged
@doug-walker
Copy link
Contributor

Found a bug: The Rec.2100-PQ Display does not have the view "ACES 2.0 - HDR 4000 nits (P3 D65)", which it is supposed to have. Applies to both the D65 and All versions.

@mjtitchener-fn
Copy link

@KelSolaar Thanks for all of your effort on this (and in general)!

The defaults for active_displays and active_views look good to me now.

The code has not changed at all since my last update, the active_views looks like this for me, it is different for you?

This made me wonder which config everyone is testing/referring to? I've mainly been using studio-config-v2.3.0_aces-v2.0_ocio-v2.4.ocio.txt as I believe this is the one we'll be promoting as the "main" config for use/inclusion in DCCs?

The active_views example in this post from @KelSolaar though is from studio-config-all-views-v2.3.0_aces-v2.0_ocio-v2.4.ocio.txt.

Both are valid of course but it could result in confusion if we're looking at different things.

@KelSolaar
Copy link
Contributor Author

I think that I finally figured out what is happening in the depth of the Reference config generator and producing unpredictable ordering. I'll do more tests.

@KelSolaar
Copy link
Contributor Author

Ok, OP updated, involved deep and dangerous changes to the reference config generator that everything depends on, hopefully, nothing broke. It is extremely painful not being able to test this with confidence. @mjtitchener-fn : You are my eyes here, let me know! :)

@mjtitchener-fn
Copy link

Something's gone wrong unforunately. There's a lot of repetion of views in each display e.g.

Screenshot 2025-03-06 at 12 55 24 Screenshot 2025-03-06 at 12 48 30

@mjtitchener-fn
Copy link

Here's a comparison of the the active_views in studio-config-v2.3.0_aces-v2.0_ocio-v2.4.ocio, before and after your change.

BEFORE:

active_views: [
ACES 2.0 - HDR 1000 nits (P3 D65),
ACES 2.0 - HDR 500 nits (P3 D65),
ACES 2.0 - HDR 2000 nits (P3 D65),
ACES 2.0 - HDR 4000 nits (P3 D65),
ACES 2.0 - HDR 500 nits (Rec.2020),
ACES 2.0 - HDR 1000 nits (Rec.2020),
ACES 2.0 - HDR 2000 nits (Rec.2020),
ACES 2.0 - HDR 4000 nits (Rec.2020),
ACES 2.0 - HDR 108 nits (P3 D65),
ACES 2.0 - SDR 100 nits (Rec.709),
ACES 2.0 - SDR 100 nits (P3 D65), 
Un-tone-mapped,
Raw]

AFTER:

active_views: [
ACES 2.0 - HDR 108 nits (P3 D65), 
ACES 2.0 - HDR 500 nits (P3 D65),
ACES 2.0 - HDR 500 nits (Rec.2020),
ACES 2.0 - HDR 500 nits (P3 D65),
ACES 2.0 - HDR 1000 nits (P3 D65),
ACES 2.0 - HDR 1000 nits (P3 D65),
ACES 2.0 - HDR 1000 nits (P3 D65),
ACES 2.0 - HDR 1000 nits (Rec.2020),
ACES 2.0 - HDR 1000 nits (P3 D65),
ACES 2.0 - HDR 2000 nits (P3 D65),
ACES 2.0 - HDR 2000 nits (Rec.2020),
ACES 2.0 - HDR 2000 nits (P3 D65),
ACES 2.0 - HDR 4000 nits (P3 D65),
ACES 2.0 - HDR 4000 nits (Rec.2020),
ACES 2.0 - HDR 4000 nits (P3 D65),
ACES 2.0 - SDR 100 nits (Rec.709),
ACES 2.0 - SDR 100 nits (P3 D65),
ACES 2.0 - SDR 100 nits (P3 D65),
ACES 2.0 - SDR 100 nits (Rec.709),
ACES 2.0 - SDR 100 nits (Rec.709),
ACES 2.0 - SDR 100 nits (P3 D65),
ACES 2.0 - SDR 100 nits (Rec.709),
ACES 2.0 - SDR 100 nits (Rec.709),
ACES 2.0 - SDR 100 nits (Rec.709),
ACES 2.0 - SDR 100 nits (Rec.709),
Un-tone-mapped,
Raw]

@KelSolaar
Copy link
Contributor Author

KelSolaar commented Mar 6, 2025 •
edited
Loading

Thanks for checking, one step forward, i.e., things are ordered properly but two backwards, i.e., there is now duplication (which is why I was grouping the spreadsheet elements in a particular way before when building the internal data).

This should be an easy fix and I have ocioview finally running so it should be able to also test now!

@KelSolaar
Change reference config generation to honour spreadsheet ordering dur…
493ef9e 
…ing config mapping generation.

Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>
@KelSolaar
Copy link
Contributor Author

@mjtitchener-fn: I did a one liner change that should avoid duplication, cursory check of the internal data and in OCIO view seems to show that things are trending in the correct direction. Let me know, I need to jump on the other job.

@KelSolaar KelSolaar marked this pull request as ready for review March 9, 2025 04:03
@mjtitchener-fn
Copy link

Thanks @KelSolaar, yep this has fixed the duplication problem.
For clarity here’s what I’m seeing as the default view for each display.
This is using studio-config-v2.3.0_aces-v2.0_ocio-v2.4.ocio

sRGB - Display
ACES 2.0 - SDR 100 nits (Rec.709)

Display P3 - Display
ACES 2.0 - SDR 100 nits (P3 D65)

Display P3 HDR - Display
ACES 2.0 - HDR 1000 nits (P3 D65)

P3-D65 - Display
ACES 2.0 - SDR 100 nits (Rec.709)
Should this default to ACES 2.0 - SDR 100 nits (P3 D65) instead?

Rec.1886 Rec.709 - Display
ACES 2.0 - SDR 100 nits (Rec.709)*

Rec.2100-HLG - Display
ACES 2.0 - HDR 1000 nits (P3 D65)
Only a P3 D65 view is available for HLG. Given this is Rec.2100 shouldn't a Rec.2020 view be available and default?

Rec.2100-PQ - Display
ACES 2.0 - HDR 500 nits (P3 D65)
As above if this is Rec.2100 should a Rec.2020 view be default (they are avaiable for this display). Also would 1000 nits be preferential as a default?

ST2084-P3-D65 - Display
ACES 2.0 - HDR 108 nits (P3 D65)
I would've thought this should default to ACES 2.0 - HDR 500 nits (P3 D65) or ACES 2.0 - HDR 1000 nits (P3 D65)?

I know it’s hard to have it all ways when setting rules to do to this programitically and users can ultimately select what's right for their workflow. Just thinking out loud about what the best starting points are 🤔

@doug-walker
Copy link
Contributor

doug-walker commented Mar 9, 2025 •
edited
Loading

@mjtitchener-fn , thanks for testing this! Regarding HLG, the ACES 2 working group only made the 1000 nit P3 flavor available. My impression is that P3 is the preferred default across the different HDR displays since with Rec.2020 one cannot see it yet (except with various exotic displays) and so there is not the ability to confidently master to that yet. I would make the 1000 nit P3 the default for those last three items in your list.

The P3-D65 display's view should indeed be P3 but it should also be named 48 nit (even though it is using the same view transform as the 100 nit). I was wondering if we need to create a duplicate view transform with that name in OCIO to be used for the config generator.

@doug-walker
Copy link
Contributor

doug-walker commented Mar 11, 2025 •
edited
Loading

@KelSolaar , per my action item from today's meeting, please make the following changes to the active_views lists. The rest of the configs look mostly ok. With the following exceptions:

  1. The AMF data in the view transform descriptions went haywire, and there is a lot of extra incorrect stuff now. If you are able to easily turn off the AMF descriptions for now, that would be great. Otherwise it's ok, though the volume of stuff is large, especially in the D60 config.
  2. The D60 config is missing the Raw and Un-tone-mapped views. If it's difficult to add these easily, please remove this config for now.
  3. For the CG config, could you remove the D60 and All versions from the generator? If not, let me know and I'll do the active_views for those.
  4. As mentioned previously, the "P3-D65 - Display" and "DCDM-D65 - Display" are using "100 nits" views, despite the name having "48 nits" in the CTLs.

Active view list for config: studio-config-v2.3.0_aces-v2.0_ocio-v2.4.ocio
active_views: [ACES 2.0 - HDR 1000 nits (P3 D65), ACES 2.0 - HDR 1000 nits (Rec.2020), ACES 2.0 - HDR 2000 nits (P3 D65), ACES 2.0 - HDR 2000 nits (Rec.2020), ACES 2.0 - HDR 4000 nits (P3 D65), ACES 2.0 - HDR 4000 nits (Rec.2020), ACES 2.0 - HDR 500 nits (P3 D65), ACES 2.0 - HDR 500 nits (Rec.2020), ACES 2.0 - HDR 108 nits (P3 D65), ACES 2.0 - SDR 100 nits (P3 D65), ACES 2.0 - SDR 100 nits (Rec.709), Un-tone-mapped, Raw]

The default views will then be as follows:

sRGB - Display :   ACES 2.0 - SDR 100 nits (Rec.709)
Display P3 - Display :   ACES 2.0 - SDR 100 nits (P3 D65)
Display P3 HDR - Display :   ACES 2.0 - HDR 1000 nits (P3 D65)
P3-D65 - Display :   ACES 2.0 - SDR 100 nits (P3 D65)
Rec.1886 Rec.709 - Display :   ACES 2.0 - SDR 100 nits (Rec.709)
Rec.2100-HLG - Display :   ACES 2.0 - HDR 1000 nits (P3 D65)
Rec.2100-PQ - Display :   ACES 2.0 - HDR 1000 nits (P3 D65)
ST2084-P3-D65 - Display :   ACES 2.0 - HDR 1000 nits (P3 D65)

Active view list for config: studio-config-d60-views-v2.3.0_aces-v2.0_ocio-v2.4.ocio
active_views: [ACES 2.0 - HDR 1000 nits (P3 D60 in P3 D65), ACES 2.0 - HDR 1000 nits (P3 D60 in Rec.2020 D65), ACES 2.0 - HDR 1000 nits (Rec.2020 D60 in Rec.2020 D65), ACES 2.0 - HDR 2000 nits (P3 D60 in Rec.2020 D65), ACES 2.0 - HDR 2000 nits (Rec.2020 D60 in Rec.2020 D65), ACES 2.0 - HDR 2000 nits (P3 D60 in P3 D65), ACES 2.0 - HDR 4000 nits (P3 D60 in Rec.2020 D65), ACES 2.0 - HDR 4000 nits (Rec.2020 D60 in Rec.2020 D65), ACES 2.0 - HDR 4000 nits (P3 D60 in P3 D65), ACES 2.0 - HDR 500 nits (P3 D60 in Rec.2020 D65), ACES 2.0 - HDR 500 nits (Rec.2020 D60 in Rec.2020 D65), ACES 2.0 - HDR 500 nits (P3 D60 in P3 D65), ACES 2.0 - HDR 108 nits (P3 D60 in P3 D65), ACES 2.0 - SDR 100 nits (P3 D60 in P3 D65), ACES 2.0 - SDR 100 nits (Rec.709 D60 in P3 D65), ACES 2.0 - SDR 100 nits (Rec.709 D60 in Rec.2020 D65), ACES 2.0 - SDR 100 nits (Rec.709 D60 in Rec.709 D65), Un-tone-mapped, Raw]

The default views will then be as follows:

sRGB - Display :   ACES 2.0 - SDR 100 nits (Rec.709 D60 in Rec.709 D65)
Display P3 - Display :   ACES 2.0 - SDR 100 nits (P3 D60 in P3 D65)
Display P3 HDR - Display :   ACES 2.0 - HDR 1000 nits (P3 D60 in P3 D65)
P3-D65 - Display :   ACES 2.0 - SDR 100 nits (P3 D60 in P3 D65)
Rec.1886 Rec.709 - Display :   ACES 2.0 - SDR 100 nits (Rec.709 D60 in Rec.709 D65)
Rec.2100-HLG - Display :   ACES 2.0 - HDR 1000 nits (P3 D60 in Rec.2020 D65)
Rec.2100-PQ - Display :   ACES 2.0 - HDR 1000 nits (P3 D60 in Rec.2020 D65)
ST2084-P3-D65 - Display :   ACES 2.0 - HDR 1000 nits (P3 D60 in P3 D65)

Active view list for config: studio-config-all-views-v2.3.0_aces-v2.0_ocio-v2.4.ocio
active_views: [ACES 2.0 - HDR 1000 nits (P3 D65), ACES 2.0 - HDR 1000 nits (Rec.2020), ACES 2.0 - HDR 1000 nits (P3 D60 in P3 D65), ACES 2.0 - HDR 1000 nits (P3 D60 in Rec.2020 D65), ACES 2.0 - HDR 1000 nits (Rec.2020 D60 in Rec.2020 D65), ACES 2.0 - HDR 2000 nits (P3 D65), ACES 2.0 - HDR 2000 nits (Rec.2020), ACES 2.0 - HDR 2000 nits (P3 D60 in P3 D65), ACES 2.0 - HDR 2000 nits (P3 D60 in Rec.2020 D65), ACES 2.0 - HDR 2000 nits (Rec.2020 D60 in Rec.2020 D65), ACES 2.0 - HDR 4000 nits (P3 D65), ACES 2.0 - HDR 4000 nits (Rec.2020), ACES 2.0 - HDR 4000 nits (P3 D60 in P3 D65), ACES 2.0 - HDR 4000 nits (P3 D60 in Rec.2020 D65), ACES 2.0 - HDR 4000 nits (Rec.2020 D60 in Rec.2020 D65), ACES 2.0 - HDR 500 nits (P3 D65), ACES 2.0 - HDR 500 nits (Rec.2020), ACES 2.0 - HDR 500 nits (P3 D60 in P3 D65), ACES 2.0 - HDR 500 nits (P3 D60 in Rec.2020 D65), ACES 2.0 - HDR 500 nits (Rec.2020 D60 in Rec.2020 D65), ACES 2.0 - HDR 108 nits (P3 D65), ACES 2.0 - HDR 108 nits (P3 D60 in P3 D65), ACES 2.0 - SDR 100 nits (P3 D65), ACES 2.0 - SDR 100 nits (P3 D60 in P3 D65), ACES 2.0 - SDR 100 nits (Rec.709), ACES 2.0 - SDR 100 nits (Rec.709 D60 in P3 D65), ACES 2.0 - SDR 100 nits (Rec.709 D60 in Rec.2020 D65), ACES 2.0 - SDR 100 nits (Rec.709 D60 in Rec.709 D65), Un-tone-mapped, Raw]

The default views will then be as follows:

sRGB - Display :   ACES 2.0 - SDR 100 nits (Rec.709)
Display P3 - Display :   ACES 2.0 - SDR 100 nits (P3 D65)
Display P3 HDR - Display :   ACES 2.0 - HDR 1000 nits (P3 D65)
P3-D65 - Display :   ACES 2.0 - SDR 100 nits (P3 D65)
Rec.1886 Rec.709 - Display :   ACES 2.0 - SDR 100 nits (Rec.709)
Rec.2100-HLG - Display :   ACES 2.0 - HDR 1000 nits (P3 D65)
Rec.2100-PQ - Display :   ACES 2.0 - HDR 1000 nits (P3 D65)
ST2084-P3-D65 - Display :   ACES 2.0 - HDR 1000 nits (P3 D65)

Active view list for config: cg-config-v2.3.0_aces-v2.0_ocio-v2.4.ocio
active_views: [ACES 2.0 - HDR 1000 nits (P3 D65), ACES 2.0 - HDR 1000 nits (Rec.2020), ACES 2.0 - HDR 2000 nits (P3 D65), ACES 2.0 - HDR 2000 nits (Rec.2020), ACES 2.0 - HDR 4000 nits (P3 D65), ACES 2.0 - HDR 4000 nits (Rec.2020), ACES 2.0 - HDR 500 nits (P3 D65), ACES 2.0 - HDR 500 nits (Rec.2020), ACES 2.0 - SDR 100 nits (P3 D65), ACES 2.0 - SDR 100 nits (Rec.709), Un-tone-mapped, Raw]

The default views will then be as follows:

sRGB - Display :   ACES 2.0 - SDR 100 nits (Rec.709)
Display P3 - Display :   ACES 2.0 - SDR 100 nits (P3 D65)
Display P3 HDR - Display :   ACES 2.0 - HDR 1000 nits (P3 D65)
P3-D65 - Display :   ACES 2.0 - SDR 100 nits (P3 D65)
Rec.1886 Rec.709 - Display :   ACES 2.0 - SDR 100 nits (Rec.709)
Rec.2100-PQ - Display :   ACES 2.0 - HDR 1000 nits (P3 D65)

Active view list for config: reference-config-v2.3.0_aces-v2.0_ocio-v2.4.ocio
active_views: [ACES 2.0 - HDR 1000 nits (P3 D65), ACES 2.0 - HDR 1000 nits (Rec.2020), ACES 2.0 - HDR 1000 nits (P3 D60 in P3 D65), ACES 2.0 - HDR 1000 nits (P3 D60 in Rec.2020 D65), ACES 2.0 - HDR 1000 nits (Rec.2020 D60 in Rec.2020 D65), ACES 2.0 - HDR 2000 nits (P3 D65), ACES 2.0 - HDR 2000 nits (Rec.2020), ACES 2.0 - HDR 2000 nits (P3 D60 in P3 D65), ACES 2.0 - HDR 2000 nits (P3 D60 in Rec.2020 D65), ACES 2.0 - HDR 2000 nits (Rec.2020 D60 in Rec.2020 D65), ACES 2.0 - HDR 4000 nits (P3 D65), ACES 2.0 - HDR 4000 nits (Rec.2020), ACES 2.0 - HDR 4000 nits (P3 D60 in P3 D65), ACES 2.0 - HDR 4000 nits (P3 D60 in Rec.2020 D65), ACES 2.0 - HDR 4000 nits (Rec.2020 D60 in Rec.2020 D65), ACES 2.0 - HDR 500 nits (P3 D65), ACES 2.0 - HDR 500 nits (Rec.2020), ACES 2.0 - HDR 500 nits (P3 D60 in P3 D65), ACES 2.0 - HDR 500 nits (P3 D60 in Rec.2020 D65), ACES 2.0 - HDR 500 nits (Rec.2020 D60 in Rec.2020 D65), ACES 2.0 - HDR 300 nits (P3 D65), ACES 2.0 - HDR 300 nits (P3 D60 in XYZ E), ACES 2.0 - HDR 108 nits (P3 D65), ACES 2.0 - HDR 108 nits (P3 D60 in P3 D65), ACES 2.0 - SDR 100 nits (P3 D65), ACES 2.0 - SDR 100 nits (P3 D60 in P3 D65), ACES 2.0 - SDR 100 nits (Rec.709), ACES 2.0 - SDR 100 nits (Rec.709 D60 in P3 D65), ACES 2.0 - SDR 100 nits (Rec.709 D60 in Rec.2020 D65), ACES 2.0 - SDR 100 nits (Rec.709 D60 in Rec.709 D65), ACES 2.0 - SDR 100 nits (P3 D60 in XYZ E), Un-tone-mapped, Raw]

The default views will then be as follows:

sRGB - Display :   ACES 2.0 - SDR 100 nits (Rec.709)
DCDM-D65 - Display :   ACES 2.0 - SDR 100 nits (P3 D65)
Display P3 - Display :   ACES 2.0 - SDR 100 nits (P3 D65)
Display P3 HDR - Display :   ACES 2.0 - HDR 1000 nits (P3 D65)
G2.2 Rec.709 - Display :   ACES 2.0 - SDR 100 nits (Rec.709)
P3-D65 - Display :   ACES 2.0 - SDR 100 nits (P3 D65)
Rec.1886 Rec.709 - Display :   ACES 2.0 - SDR 100 nits (Rec.709)
Rec.2100-HLG - Display :   ACES 2.0 - HDR 1000 nits (P3 D65)
Rec.2100-PQ - Display :   ACES 2.0 - HDR 1000 nits (P3 D65)
ST2084-DCDM-D65 - Display :   ACES 2.0 - HDR 300 nits (P3 D65)
ST2084-P3-D65 - Display :   ACES 2.0 - HDR 1000 nits (P3 D65)

@KelSolaar
Copy link
Contributor Author

KelSolaar commented Mar 11, 2025 •
edited
Loading

Thanks @doug-walker!

  1. As we talk quite a few times, the AMF components should really come from somewhere else than the Config generator. There should be a file / database somewhere on the Academy side that we can pull from as required. Disabled for now! Actually, looking at it, this is a side effect of the changes I made for the ordering...
  2. Good catch, and /done.
  3. Easy! /done.
  4. The View name is programmatically derived from the BuiltinTransform, and there is not 48nit one, not much I can do unfortunately!
>>> [k for k in opencolorio_config_aces.BUILTIN_TRANSFORMS if "48nit" in k]
[]
>>> [k for k in opencolorio_config_aces.BUILTIN_TRANSFORMS if "100nit" in k]
['ACES-OUTPUT - ACES2065-1_to_CIE-XYZ-D65 - SDR-100nit-REC709_2.0', 'ACES-OUTPUT - ACES2065-1_to_CIE-XYZ-D65 - SDR-100nit-P3-D65_2.0', 'ACES-OUTPUT - ACES2065-1_to_CIE-XYZ-D65 - SDR-100nit-REC709-D60-in-REC709-D65_2.0', 'ACES-OUTPUT - ACES2065-1_to_CIE-XYZ-D65 - SDR-100nit-REC709-D60-in-P3-D65_2.0', 'ACES-OUTPUT - ACES2065-1_to_CIE-XYZ-D65 - SDR-100nit-REC709-D60-in-REC2020-D65_2.0', 'ACES-OUTPUT - ACES2065-1_to_CIE-XYZ-D65 - SDR-100nit-P3-D60-in-P3-D65_2.0', 'ACES-OUTPUT - ACES2065-1_to_CIE-XYZ-D65 - SDR-100nit-P3-D60-in-XYZ-E_2.0']

I will work on the active views ordering now.

@KelSolaar
Fix *AMF* components generation.
476863b 
Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>
@KelSolaar
Ensure that Un-tone-mapped and Raw views are present in the *D60 …
197f31d 
…Views* configs.

Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>
@KelSolaar
Ensure that only the *D65* variant of the *CG* config is built.
34a4050 
Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>
@KelSolaar
Refine active views ordering.
b1879b9 
Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>
@KelSolaar
Copy link
Contributor Author

OP updated, the ordering should match for most of the configs but:

  • There are some minor differences for the D60 variant, its is currently the result from the filtering all the other views so maintains the order of the all-views.
  • The CG config has less displays, I'm not sure why we had the 500, 2000 and 4000 nits displays.

I fixed an error introduced whilst doing the Reference config changes for the ordering, this should have sorted most of the descriptions and the AMF components I think.

@doug-walker
Copy link
Contributor

Thanks for the update @KelSolaar ! The Reference and Studio configs now look fine to me. Unfortunately, I made an error when I reviewed the CG config. For ACES 1.3 we only included the HDR 1000 nit view and our displays list included "ST2084-P3-D65 - Display". I think we should continue likewise for the ACES 2 configs. You already fixed my error of including the non-1000 nit HDR views, so the active_views list is correct. Please just add the "ST2084-P3-D65 - Display" display to the CG config and we should be good to release.

@KelSolaar
Add P3-D65_1000nit_in_P3-D65_ST2084.
02a701c 
Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>
@KelSolaar
Copy link
Contributor Author

CG config is updated, I added P3-D65_1000nit_in_P3-D65_ST2084 to it.

@doug-walker
Copy link
Contributor

Thank you @KelSolaar, all issues now seem to have been addressed. Please proceed with the release!! :)

doug-walker
doug-walker approved these changes Mar 13, 2025
View reviewed changes
Copy link
Contributor

@doug-walker doug-walker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Awesome work Thomas!

@KelSolaar KelSolaar merged commit 6836aba into AcademySoftwareFoundation:main Mar 14, 2025
6 checks passed
@KelSolaar KelSolaar deleted the feature/aces-2.0 branch March 14, 2025 19:26
@doug-walker doug-walker mentioned this pull request Mar 18, 2025
Closed
@KelSolaar KelSolaar mentioned this pull request Mar 18, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doug-walker doug-walker doug-walker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@KelSolaar @carolalynn @doug-walker @mjtitchener-fn @scottdyer