-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: ACES 1.x Varnishing #132
PR: ACES 1.x Varnishing #132
Conversation
Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>
8e5d35f
to
bb09ac0
Compare
…ew transforms list for *OpenColorIO* profile lesser or equal to 2.3. Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>
…rop Forum* recommendations. Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>
7f785f8
to
44af79a
Compare
@doug-walker: This should also include the new names from #127. |
Thanks Thomas, I've reviewed the CG and Studio artifacts and will suggest the following changes:
|
Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>
37c4821
to
2b25a54
Compare
Should not be too far now! Sorry about 5., completely forgot to add the code to the Studio Config. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are looking great, Thomas! I don't think I have any additional notes from what Doug mentioned.
I'm wondering if the ordering of the Utility family could be improved. Currently it is this:
Perhaps an ordering along these lines would be better? Any opinions?
|
Items 1-5 above have been addressed! Here's a few other observations. I don't think they require action, but are probably worth noting.
Note that the color space version is sometimes 2.1.0 and others 2.2.0, even though the contents of all of these is basically the same in terms of the updated naming of existing color spaces. One could argue that the ones that are 2.1.0 are correct in the sense that the previous version of those configs was 2.0.0. Alternatively, one could argue that it's simpler for people if "color space version 2.1" always means basically the same thing, even if that means skipping a version. I have no objections to the current scheme, but wanted to mention it.
|
Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>
Yes, this was also done for disambiguation! Colorspace(s) and NamedTransform(s) should be ordered as per-above suggestion! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the changes Thomas, these look great!
There is one more small naming issue currently being discussed, so I'm not sure if you prefer to merge this now or wait, but I'll approve now to give you the flexibility.
Let's wait for the naming issue resolution. |
Merging for now because AcademySoftwareFoundation/OpenColorIO#2039 is up and ready! |
This PR updates various aliases and names according to VWG discussions and also sets the Un-tone-mapped view transform first in the list of view transforms for OCIO profiles <=2.3.