Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move GPU LUT files into the tests dir #2069

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ananthb
Copy link

@ananthb ananthb commented Sep 30, 2024

Closes #2017.

Instead of creating temporary LUT files for GPU tests, store them in source code instead.
This removes the need to clean them up after each run.

Copy link

linux-foundation-easycla bot commented Sep 30, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: ananthb / name: Ananth (073cbd5)

@carolalynn carolalynn added the devdays24 Label for PRs for Dev Days 2024. label Sep 30, 2024
@ananthb ananthb force-pushed the lut_data_files branch 2 times, most recently from 102a06d to 95c0b03 Compare October 1, 2024 11:02
Instead of creating temporary LUT files for GPU tests,
read them from the testdata directory instead.

This removes the need to clean them up after each run.

Signed-off-by: Ananth Bhaskararaman <ananth.b@qubecinema.com>
@ananthb
Copy link
Author

ananthb commented Oct 4, 2024

I think I fixed the test again, but I'm not sure what the context tests are about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devdays24 Label for PRs for Dev Days 2024.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Lut3D GPU unit test to not create temporary files
2 participants