-
Notifications
You must be signed in to change notification settings - Fork 390
Add Conda environment setup and dependency installation script #2023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This script sets up the development environment by: - Creating a Conda environment - Installing all required dependencies - Cloning the forked repository for development Enables contributors to quickly replicate a working environment. Signed-off-by: Alexandru Biscoveanu <alex.biscoveanu.gfx@gmail.com>
Maybe put this script in the src/build-scripts directory? |
cmake \ | ||
llvmdev=20.1.8 clangdev clangxx_linux-64 libcxx \ | ||
python=3.12 numpy pybind11 \ | ||
openimageio=2.5 imath flex bison pugixml zlib |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's pretty old. Can we use at least OpenImageIO 3.0 by default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like conda-forge has up to v2.5.18.0
sadly :/
https://anaconda.org/conda-forge/openimageio
Maybe mamba
could be an alternative?
https://openmamba.org/en/rpms/base/python-OpenImageIO/aarch64/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What we could do is, download from the OpenImageIO repo binaries and install them directly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The OpenImageIO repo does not currently provide pre-built binaries.
However, this OSL repo already has a src/build-scripts/build_openimageio.bash that can build OIIO from scratch.
I think this could be pretty useful for people. Can you add some documentation to "INSTALL.md" explaining how to use it? |
@@ -0,0 +1,51 @@ | |||
#!/bin/bash | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add the customary copyright notice here.
# Copyright Contributors to the Open Shading Language project. | |
# SPDX-License-Identifier: BSD-3-Clause | |
# https://github.com/AcademySoftwareFoundation/OpenShadingLanguage | |
I think that to wrap up this PR, we're primarily waiting for some modification to INSTALL.md instructions to explain briefly how and when to use it. |
Description
This script sets up the development environment by:
Enables contributors to quickly replicate a working environment.
Tests
Checklist:
already run clang-format v17 before submitting, I definitely will look at
the CI test that runs clang-format and fix anything that it highlights as
being nonconforming.