Add missing log4cplus/version.h include #1641
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the logging.h header checks the LOG4CPLUS_VERSION macro to determine whether to use std::auto_ptr or std::unique_ptr. However, the LOG4CPLUS_VERSION macro is defined in log4cplus/version.h, which is not explicitlyincluded from logging.h. Explicitly include log4cplus/version.h to ensure that the LOG4CPLUS_VERSION macro is defined. Signed-off-by: Violet Purcell <vimproved@inventati.org>
|
|
Idclip
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the logging.h header checks the LOG4CPLUS_VERSION macro to determine whether to use std::auto_ptr or std::unique_ptr. However, the LOG4CPLUS_VERSION macro is defined in log4cplus/version.h, which is not explicitlyincluded from logging.h. Explicitly include log4cplus/version.h to ensure that the LOG4CPLUS_VERSION macro is defined.