Only emit SIMD compiler flags on x86-based platforms #1645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enabling the SSE4.2 or AVX SIMD flags on non-x86 based platforms will result in a compilation error stating that the -msse4.2 and -mavx flags cannot be found. This patch causes the flags to only be emitted on x86-based platforms. Signed-off-by: jmather-sesi <54645798+jmather-sesi@users.noreply.github.com>
jmather-sesi
force-pushed
the
non-x86-intrinsic-flag-fix
branch
from
3ab46a4
to
c68dccb
Compare
Signed-off-by: jmather-sesi <54645798+jmather-sesi@users.noreply.github.com>
jmather-sesi
requested review from
kmuseth,
apradhana,
jmlait,
Idclip,
danrbailey and
richhones
as code owners
Idclip
approved these changes
Aug 1, 2023
danrbailey
approved these changes
Aug 1, 2023
jmlait
merged commit 3f8b6f3
into
AcademySoftwareFoundation:master
40 of 41 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling the SSE4.2 or AVX SIMD flags on non-x86 based platforms will result in a compilation error stating that the -msse4.2 and -mavx flags cannot be found. This patch causes the flags to only be emitted on x86-based platforms.