Bug fix: the half type doesn't satisfy std::is_arithmetic so the operator doesn't get instantiated #1893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hmetic so the operator doesn't get instantiated. Signed-off-by: apradhana <andre.pradhana@gmail.com>
jmlait
approved these changes
Sep 10, 2024
danrbailey
approved these changes
Sep 10, 2024
apradhana
merged commit 5a547f1
into
AcademySoftwareFoundation:master
8 of 46 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are adding
cwiseAddtemplate specialization onhalftype forVec3class. This is to address the issue encountered in PR-1723.