Use parameter_types instead of thread_local #2719
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2719 +/- ##
==========================================
- Coverage 67.21% 66.71% -0.50%
==========================================
Files 68 67 -1
Lines 9567 8500 -1067
==========================================
- Hits 6430 5671 -759
+ Misses 3137 2829 -308 ☔ View full report in Codecov by Sentry. |
zjb0807
force-pushed
the
use-parameter_types
branch
from
c93c296 to
bee5207
Compare
|
fix #2716 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
paritytech/substrate#10479
paritytech/substrate#12036
should fix tarpaulin issue