improve logging #767
improve logging #767
Conversation
packages/chopsticks/src/logger.ts
Outdated
| process.platform === 'win32' ? ['-', '\\', '|', '/'] : ['⠋', '⠙', '⠹', '⠸', '⠼', '⠴', '⠦', '⠧', '⠇', '⠏'] | ||
| let index = 0 | ||
|
|
||
| const clearStatus = _.debounce(() => process.stdout.clearLine(1), 500, { trailing: true }) |
There was a problem hiding this comment.
It clear from cursor to right. Best explained if you run it
There was a problem hiding this comment.
I am asking if it is possible to have other log printed in between and this ended up of clear the other log instead
There was a problem hiding this comment.
no because it prints "Fetching" and moves the cursor at the beginning and the clear is done from cursor position to the right.
There was a problem hiding this comment.
I'm creating another PR this
packages/core/src/api.ts
Outdated
| this.#apiHooks.fetching = fetching | ||
| } | ||
|
|
||
| fetching = _.throttle( |
There was a problem hiding this comment.
maybe we can have the throttle logic on the handler instead? so this is get called on every fetch. just to make the API less complicated
There was a problem hiding this comment.
That work as well
There was a problem hiding this comment.
the main thing about denouncing logic is that it is often we forget to clear the timer at destructor and it could cause issue for example this is used in unit tests and creating many Chopsticks instances
ermalkaleci
changed the title
TODO: another PR to add colors
