Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix block hash #790

Merged
merged 10 commits into from
Jul 11, 2024
Merged

fix block hash #790

merged 10 commits into from
Jul 11, 2024

Conversation

xlc
Copy link
Member

@xlc xlc commented Jul 10, 2024

previously block hash is always the same as only the header hash is considered and the extrinsicRoot was mocked to zeros

@xlc xlc requested a review from ermalkaleci July 10, 2024 11:51
@xlc xlc enabled auto-merge (squash) July 10, 2024 11:53
packages/core/src/blockchain/block-builder.ts Outdated Show resolved Hide resolved
packages/e2e/src/block.test.ts Outdated Show resolved Hide resolved
xlc and others added 2 commits July 11, 2024 11:08
Co-authored-by: Ermal Kaleci <ermalkaleci@gmail.com>
Co-authored-by: Ermal Kaleci <ermalkaleci@gmail.com>
@xlc xlc disabled auto-merge July 10, 2024 23:08
@xlc xlc merged commit f482f81 into master Jul 11, 2024
6 checks passed
@xlc xlc deleted the fix-block-hash branch July 11, 2024 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants