feat: add transaction_v1 group of functions #819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ermalkaleci
reviewed
Sep 9, 2024
ermalkaleci
reviewed
Sep 9, 2024
ermalkaleci
reviewed
Sep 9, 2024
ermalkaleci
reviewed
Sep 9, 2024
ermalkaleci
reviewed
Sep 9, 2024
voliva
force-pushed
the
transaction_v1
branch
from
ca1edda
to
3c35a81
Compare
xlc
reviewed
Sep 11, 2024
ermalkaleci
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
transaction_v1group of functions of the JSON RPC interface spec into the RPC server.It's fairly simple, since it's only two functions: one starting a broadcast, and the other to stop it.
We'll be missing only one last group to make it fully compatible with papi, the
chainSpecone. Looks fairly simple, will work on it next and raise as a separate PR.