Skip to content

Updated golangci-lint dev dependency and migrated config. #3766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: version/0-48-1-RC1
Choose a base branch
from
Open

Updated golangci-lint dev dependency and migrated config. #3766

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
110 changes: 57 additions & 53 deletions .golangci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,53 +1,57 @@
issues:
exclude-dirs:
- vendor
exclude-rules:
- linters:
- staticcheck
text: "SA9004"

linters-settings:
errcheck:
exclude-functions:
- fmt.Fprintln
- (*github.com/ActiveState/termtest.TermTest).Expect
- (*github.com/ActiveState/termtest.TermTest).ExpectExitCode
- (*github.com/ActiveState/termtest.TermTest).ExpectNotExitCode
- (*github.com/ActiveState/termtest.TermTest).ExpectRe
- (*github.com/ActiveState/termtest.TermTest).Expect
- (*github.com/ActiveState/termtest.TermTest).WaitForInput
- (*github.com/ActiveState/termtest.TermTest).SendLine
- (*github.com/ActiveState/termtest.TermTest).ExpectInput
- (*github.com/ActiveState/termtest.TermTest).ExpectExit
- (*github.com/ActiveState/termtest.TermTest).Wait
- (*github.com/ActiveState/logging.fileHandler).Printf
- (*github.com/ActiveState/logging.standardHandler).Printf
- (*github.com/ActiveState/cli/internal/testhelpers/e2e.Session).Close
- (*github.com/ActiveState/cli/internal/testhelpers/e2e.SpawnedCmd).ExpectInput
- (*github.com/ActiveState/cli/internal/testhelpers/e2e.SpawnedCmd).Send
- (*github.com/ActiveState/cli/internal/testhelpers/e2e.SpawnedCmd).SendLine
- (*github.com/ActiveState/cli/internal/testhelpers/e2e.SpawnedCmd).SendEnter
- (*github.com/ActiveState/cli/internal/testhelpers/e2e.SpawnedCmd).SendKeyDown
- (*github.com/ActiveState/cli/internal/testhelpers/e2e.SpawnedCmd).ExpectRe
- (*github.com/ActiveState/cli/internal/testhelpers/e2e.SpawnedCmd).Wait
- (*github.com/ActiveState/cli/internal/testhelpers/e2e.Session).ClearCache
- (*github.com/ActiveState/cli/internal/testhelpers/e2e.Dirs).Close
- github.com/ActiveState/cli/internal/testhelpers/osutil.RemoveConfigFile
- (*github.com/ActiveState/cli/internal/logging.standardHandler).Emit
- (*github.com/ActiveState/cli/internal/logging.fileHandler).Emit
govet:
disable:
- composites

# When issues occur with linting us the snippet below to help with debugging
# linters:
# # Disable all and re-enable the default linters as a starting point.
# disable-all: true
# enable:
# - errcheck
# - gosimple
# - govet
# - ineffassign
# - staticcheck
# - typecheck
# - unused
version: "2"
linters:
settings:
errcheck:
exclude-functions:
- fmt.Fprintln
- (*github.com/ActiveState/termtest.TermTest).Expect
- (*github.com/ActiveState/termtest.TermTest).ExpectExitCode
- (*github.com/ActiveState/termtest.TermTest).ExpectNotExitCode
- (*github.com/ActiveState/termtest.TermTest).ExpectRe
- (*github.com/ActiveState/termtest.TermTest).Expect
- (*github.com/ActiveState/termtest.TermTest).WaitForInput
- (*github.com/ActiveState/termtest.TermTest).SendLine
- (*github.com/ActiveState/termtest.TermTest).ExpectInput
- (*github.com/ActiveState/termtest.TermTest).ExpectExit
- (*github.com/ActiveState/termtest.TermTest).Wait
- (*github.com/ActiveState/logging.fileHandler).Printf
- (*github.com/ActiveState/logging.standardHandler).Printf
- (*github.com/ActiveState/cli/internal/testhelpers/e2e.Session).Close
- (*github.com/ActiveState/cli/internal/testhelpers/e2e.SpawnedCmd).ExpectInput
- (*github.com/ActiveState/cli/internal/testhelpers/e2e.SpawnedCmd).Send
- (*github.com/ActiveState/cli/internal/testhelpers/e2e.SpawnedCmd).SendLine
- (*github.com/ActiveState/cli/internal/testhelpers/e2e.SpawnedCmd).SendEnter
- (*github.com/ActiveState/cli/internal/testhelpers/e2e.SpawnedCmd).SendKeyDown
- (*github.com/ActiveState/cli/internal/testhelpers/e2e.SpawnedCmd).ExpectRe
- (*github.com/ActiveState/cli/internal/testhelpers/e2e.SpawnedCmd).Wait
- (*github.com/ActiveState/cli/internal/testhelpers/e2e.Session).ClearCache
- (*github.com/ActiveState/cli/internal/testhelpers/e2e.Dirs).Close
- github.com/ActiveState/cli/internal/testhelpers/osutil.RemoveConfigFile
- (*github.com/ActiveState/cli/internal/logging.standardHandler).Emit
- (*github.com/ActiveState/cli/internal/logging.fileHandler).Emit
govet:
disable:
- composites
exclusions:
generated: lax
presets:
- comments
- common-false-positives
- legacy
- std-error-handling
rules:
- linters:
- staticcheck
text: SA9004
paths:
- vendor
- third_party$
- builtin$
- examples$
formatters:
exclusions:
generated: lax
paths:
- third_party$
- builtin$
- examples$
4 changes: 2 additions & 2 deletions activestate.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,12 +55,12 @@ scripts:
if: ne .Shell "cmd"
value: |
if ! type "go" &> /dev/null; then
echo "go is not installed. Please install Go version 1.23 or above."
echo "go is not installed. Please install Go version 1.24 or above."
exit 1
fi
if ! type "golangci-lint" &> /dev/null; then
echo "golangci-lint was not found on your PATH. Installing .."
go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.59.1
go install github.com/golangci/golangci-lint/cmd/golangci-lint@v2.6.2
fi
git config core.hooksPath .githooks
if ! type "swagger" &> /dev/null; then
Expand Down
Loading