Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to environment variable handling and logging in the main CLI and multiprocessing tasks, as well as adds a new utility script for managing the sharrow cache. The changes help improve debugging, stability, and cache management.
Environment variable handling and logging improvements:
activitysim/cli/main.pyto prevent multithreading by setting relevant environment variables based on command-line arguments, improving stability during benchmarking and non-fast runs.log_environment_infofunction inactivitysim/core/mp_tasks.py, which logs environment variables for debugging if theASIM_LOG_ENVIRONenvironment variable is set. This function is now called inmp_run_simulationandcheck_proc_statusto capture environment info during multiprocessing steps. [1] [2] [3]Codebase maintenance:
activitysim/core/mp_tasks.pyby moving the import of exceptions to the top and removing a duplicate import. [1] [2]New script for cache management:
other_resources/scripts/clear_sharrow_cache.py, which scans the ActivitySim cache directory for sharrow cache folders and either moves them to a timestamped archive directory or deletes them, depending on thearchiveparameter.