BayDAG Contribution #6: Joint Tour Participation Infinite Loop #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhensle
force-pushed
the
BayDAG_cont6_jtp_infinite_loop
branch
from
61292c3
to
5518ca4
Compare
i-am-sijia
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The joint tour participation model will iterate when selecting participants until the composition is met. After a set number of iterations, the model will force anyone with a non-zero probability to be in the joint tour which can help for cases where the probabilities are very small for members that need to be on the joint tour to satisfy the composition requirements. However, there can be a case where all household members with non-zero probability are forced to be on the joint tour and the tour is still not satisfied. If this happens, the current model will keep iterating in the infinite loop. This PR adds code to error out if this scenario arises so that the user can either fix their input data or their specifications (I have only seen this happen due to inconsistent reporting in survey data when running in estimation mode).
Required for SANDAG ABM3 production? -- No