BayDAG Contribution #7: Sampling in EDB for Location Choice #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhensle
force-pushed
the
BayDAG_cont7_loc_choice_sample_est
branch
from
564f07a
to
8071068
Compare
i-am-sijia
approved these changes
Mar 19, 2024
|
This non-trivial PR has not test at all to confirm it works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, estimation mode will include every single alternative for the location choice models. This can be very onerous for 2-zone systems (SANDAG's workplace location choice estimation ran took multiple hours to run). The code contributed here allows for the user to specify a sample rate to be used in estimation mode. There is an additional logic to ensure that the actual observed alternative is included in the sampled alternatives so that downstream models will be using the correct destination. Using this "shortcut" for SANDAG decreased the runtime for this model to ~10 mins instead of hours.
Note that sampling is not yet supported in the actual model estimation process in larch yet. (Something proposed for future enhancements.) This code just allows the user to run estimation mode much faster so downstream model EDBs can be created in less time.
Required for SANDAG ABM3 production? -- No